Message-ID: <1496659200.15643.15.camel@perches.com>
Subject: Re: [PATCH v3 03/17] mfd: madera: Add common support for Cirrus
 Logic Madera codecs
From: Joe Perches <joe@perches.com>
To: Lee Jones <lee.jones@linaro.org>,
        Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
Cc: broonie@kernel.org, linus.walleij@linaro.org, gnurou@gmail.com,
        robh+dt@kernel.org, tglx@linutronix.de, jason@lakedaemon.net,
        alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
        linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date: Mon, 05 Jun 2017 03:40:00 -0700
In-Reply-To: <20170605103227.no257u6v4ob65bvg@dell>
References: <1496415790-19164-1-git-send-email-rf@opensource.wolfsonmicro.com>
         <1496415790-19164-4-git-send-email-rf@opensource.wolfsonmicro.com>
         <20170605103227.no257u6v4ob65bvg@dell>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 332
Lines: 13

On Mon, 2017-06-05 at 11:32 +0100, Lee Jones wrote:
> On Fri, 02 Jun 2017, Richard Fitzgerald wrote:
[]
> >  		if (IS_ERR(madera->reset_gpio))
> > +			ret = PTR_ERR(madera->reset_gpio);
> > +		else
> > +			ret = 0;
> 
> If you pre-initialise ret, you can drop the else.

Better to use:

		ret = PTR_ERR_OR_ZERO(madera->reset_gpio);