Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751823AbdFELJ2 (ORCPT ); Mon, 5 Jun 2017 07:09:28 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:34667 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751310AbdFELJ1 (ORCPT ); Mon, 5 Jun 2017 07:09:27 -0400 Subject: Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for ever To: Rakesh Pandit , Christoph Hellwig Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Jens Axboe , Keith Busch References: <20170530071610.GA2679@hercules.tuxera.com> <4da7c939-1f54-80e5-48fc-06e58e14f018@grimberg.me> <20170530142346.GA39428@dhcp-216.srv.tuxera.com> <20170601114338.GA24855@lst.de> <20170605081817.GA22122@lst.de> <20170605105217.GA31313@dhcp-216.srv.tuxera.com> From: Sagi Grimberg Message-ID: <0666b909-e1a0-1a18-8800-b81a230de25a@grimberg.me> Date: Mon, 5 Jun 2017 14:09:00 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170605105217.GA31313@dhcp-216.srv.tuxera.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 512 Lines: 14 Rakesh, > I would post a new patch which includes my RESETTING state earlier > patch + the cancel_work_sync which Sagi suggested after testing. > > Sagi: Because my RESETTING patch earlier is subset of your untested > patch with cancel_work_sync, it would be logical to take a signed off > from you as well. May you review/ack/nack the patch? Feel free to > let me know if you want me to change it further or instead you want to > post as author. Its all yours :) send a patch and we'll review it, thanks.