From: Trond Myklebust <trondmy@primarydata.com>
To: "baijiaju1990@163.com" <baijiaju1990@163.com>,
        "anna.schumaker@netapp.com" <anna.schumaker@netapp.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] fs: nfs: Fix a sleep-in-atomic bug in
 nfs_access_add_cache
Thread-Topic: [PATCH] fs: nfs: Fix a sleep-in-atomic bug in
 nfs_access_add_cache
Thread-Index: AQHS3dIpXDpxZlvObkmGtfZIkyOg+6IWJ66A
Date: Mon, 5 Jun 2017 11:48:37 +0000
Message-ID: <1496663315.3433.1.camel@primarydata.com>
References: <1496649904-1855-1-git-send-email-baijiaju1990@163.com>
In-Reply-To: <1496649904-1855-1-git-send-email-baijiaju1990@163.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-ID: <79C7B7B18FD4CA4CA793BBBAE5FA0754@namprd11.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jun 2017 11:48:37.6989
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 03193ed6-8726-4bb3-a832-18ab0d28adb7
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1360
X-MC-Unique: MQnim8CnOeey1o1d6VwR4w-1
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v55Bn2Ae027556
Content-Length: 1277
Lines: 42

On Mon, 2017-06-05 at 16:05 +0800, Jia-Ju Bai wrote:
> The driver may sleep under a rcu read lock, and function call path
> is:
> nfs_permission (acquire the lock by rcu_read_lock)
>   nfs_do_access
>     nfs_access_add_cache
>       kmalloc(GFP_KERNEL) --> may sleep
> 
> To fix it, "GFP_KERNEL" is replaced with "GFP_ATOMIC".
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
> ---
>  fs/nfs/dir.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
> index 32ccd77..7a074db 100644
> --- a/fs/nfs/dir.c
> +++ b/fs/nfs/dir.c
> @@ -2333,7 +2333,7 @@ static void nfs_access_add_rbtree(struct inode
> *inode, struct nfs_access_entry *
>  
>  void nfs_access_add_cache(struct inode *inode, struct
> nfs_access_entry *set)
>  {
> -	struct nfs_access_entry *cache = kmalloc(sizeof(*cache),
> GFP_KERNEL);
> +	struct nfs_access_entry *cache = kmalloc(sizeof(*cache),
> GFP_ATOMIC);
>  	if (cache == NULL)
>  		return;
>  	RB_CLEAR_NODE(&cache->rb_node);

The RCU locked codepath will not ever hit nfs_access_add_rbtree(). It
returns with an error code of -ECHILD after the test of "may_block".

Cheers
  Trond
-- 
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com