Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751330AbdFEOUD (ORCPT ); Mon, 5 Jun 2017 10:20:03 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:37176 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751112AbdFEOUB (ORCPT ); Mon, 5 Jun 2017 10:20:01 -0400 Date: Mon, 05 Jun 2017 10:19:57 -0400 (EDT) Message-Id: <20170605.101957.1159360169934143154.davem@davemloft.net> To: clabbe.montjoie@gmail.com Cc: icenowy@aosc.io, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [linux-sunxi] [PATCH] net-next: stmmac: dwmac-sun8i: ensure the EPHY is properly reseted From: David Miller In-Reply-To: <20170605111019.GA29657@Red> References: <20170604175323.62124-1-icenowy@aosc.io> <20170605111019.GA29657@Red> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 05 Jun 2017 06:38:22 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1323 Lines: 32 From: Corentin Labbe Date: Mon, 5 Jun 2017 13:10:19 +0200 > On Mon, Jun 05, 2017 at 01:53:23AM +0800, Icenowy Zheng wrote: >> The EPHY may be already enabled by bootloaders which have Ethernet >> capability (e.g. current U-Boot). Thus it should be reseted properly >> before doing the enabling sequence in the dwmac-sun8i driver, otherwise >> the EMAC reset process may fail if no cable is plugged, and then fail >> the dwmac-sun8i probing. >> >> Tested on Orange Pi PC, One and Zero. All the boards fail to have >> dwmac-sun8i probed with "EMAC reset timeout" without cable plugged >> before, and with this fix they're now all able to successfully probe the >> EMAC without cable plugged and then use the connection after a cable is >> hot-plugged in. >> >> Fixes: 9f93ac8d408 ("net-next: stmmac: Add dwmac-sun8i") >> Signed-off-by: Icenowy Zheng > > Thanks for the fix. > Tested-by: Corentin Labbe > > Since I am the writter of the file, does I have the right to: > Acked-by: Corentin Labbe > or > Reviewed-by: Corentin Labbe > ? Anyone whatsoever may contribute Acked-by and Reviewed-by tags to a patch posting. This is all documented in Documentation/process/submitting-patches.rst