Message-ID: <1496672494.22624.4.camel@linux.intel.com>
Subject: Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
        Lukas Wunner <lukas@wunner.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andreas Noever <andreas.noever@gmail.com>,
        Michael Jamet <michael.jamet@intel.com>,
        Yehezkel Bernat <yehezkel.bernat@intel.com>,
        Amir Levy <amir.jer.levy@intel.com>, Andy Lutomirski <luto@kernel.org>,
        Mario.Limonciello@dell.com, Jared.Dominguez@dell.com,
        linux-kernel@vger.kernel.org
Date: Mon, 05 Jun 2017 17:21:34 +0300
In-Reply-To: <20170605133334.GM3454@lahna.fi.intel.com>
References: <20170602140524.23367-1-mika.westerberg@linux.intel.com>
         <20170602140524.23367-20-mika.westerberg@linux.intel.com>
         <20170605081437.GA7519@wunner.de>
         <20170605093249.GK3454@lahna.fi.intel.com>
         <20170605120756.GA7793@wunner.de>
         <20170605125507.GL3454@lahna.fi.intel.com>
         <20170605133334.GM3454@lahna.fi.intel.com>
Organization: Intel Finland Oy
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 712
Lines: 25

On Mon, 2017-06-05 at 16:33 +0300, Mika Westerberg wrote:
> On Mon, Jun 05, 2017 at 03:55:07PM +0300, Mika Westerberg wrote:
> > > 

> It turns out that this is not too big change after all so I think it
> can
> be included in the ICM patch if you want.
> 
> Basically we would have module parameter:
> 
> 	cm=auto|native|icm
> 
> where auto is the default.
> 
> Does that work?


I remember Greg is opposite to being fan of module parameters in new
code, so, please, if you are still going to do that, do it a separate
patch which will be last in the series and can be discussed separately
w.o. preventing everything else being applied.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy