Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751243AbdFEOpH (ORCPT ); Mon, 5 Jun 2017 10:45:07 -0400 Received: from mga03.intel.com ([134.134.136.65]:45659 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751162AbdFEOpG (ORCPT ); Mon, 5 Jun 2017 10:45:06 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,300,1493708400"; d="scan'208";a="95737991" Date: Mon, 5 Jun 2017 17:44:59 +0300 From: Mika Westerberg To: Andy Shevchenko Cc: Lukas Wunner , Greg Kroah-Hartman , Andreas Noever , Michael Jamet , Yehezkel Bernat , Amir Levy , Andy Lutomirski , Mario.Limonciello@dell.com, Jared.Dominguez@dell.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 19/27] thunderbolt: Add new Thunderbolt PCI IDs Message-ID: <20170605144459.GP3454@lahna.fi.intel.com> References: <20170602140524.23367-1-mika.westerberg@linux.intel.com> <20170602140524.23367-20-mika.westerberg@linux.intel.com> <20170605081437.GA7519@wunner.de> <20170605093249.GK3454@lahna.fi.intel.com> <20170605120756.GA7793@wunner.de> <20170605125507.GL3454@lahna.fi.intel.com> <20170605133334.GM3454@lahna.fi.intel.com> <1496672494.22624.4.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1496672494.22624.4.camel@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 805 Lines: 26 On Mon, Jun 05, 2017 at 05:21:34PM +0300, Andy Shevchenko wrote: > On Mon, 2017-06-05 at 16:33 +0300, Mika Westerberg wrote: > > On Mon, Jun 05, 2017 at 03:55:07PM +0300, Mika Westerberg wrote: > > > > > > > It turns out that this is not too big change after all so I think it > > can > > be included in the ICM patch if you want. > > > > Basically we would have module parameter: > > > > cm=auto|native|icm > > > > where auto is the default. > > > > Does that work? > > > I remember Greg is opposite to being fan of module parameters in new > code, so, please, if you are still going to do that, do it a separate > patch which will be last in the series and can be discussed separately > w.o. preventing everything else being applied. Good point, thanks! I'll add it as a separate patch then.