Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751225AbdFEP2Z (ORCPT ); Mon, 5 Jun 2017 11:28:25 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:38358 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751112AbdFEP2X (ORCPT ); Mon, 5 Jun 2017 11:28:23 -0400 Date: Mon, 05 Jun 2017 11:28:21 -0400 (EDT) Message-Id: <20170605.112821.608113849627100528.davem@davemloft.net> To: yanhaishuang@cmss.chinamobile.com Cc: arkadis@mellanox.com, jiri@mellanox.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] devlink: fix potential memort leak From: David Miller In-Reply-To: <1496624241-25794-1-git-send-email-yanhaishuang@cmss.chinamobile.com> References: <1496624241-25794-1-git-send-email-yanhaishuang@cmss.chinamobile.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 05 Jun 2017 07:46:45 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 382 Lines: 13 From: Haishuang Yan Date: Mon, 5 Jun 2017 08:57:21 +0800 > We must free allocated skb when genlmsg_put() return fails. > > Fixes: 1555d204e743 ("devlink: Support for pipeline debug (dpipe)") > Signed-off-by: Haishuang Yan > > --- > Changes in v2: > - Fix same issue in headers_fill. Applied, thank you.