Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752557AbdFERUG (ORCPT ); Mon, 5 Jun 2017 13:20:06 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33433 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752389AbdFERT6 (ORCPT ); Mon, 5 Jun 2017 13:19:58 -0400 Subject: Re: [PATCH V2] nvme: fix multiple ctrl removal scheduling To: Rakesh Pandit , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Keith Busch , Jens Axboe , Christoph Hellwig References: <20170605114309.GA31824@dhcp-216.srv.tuxera.com> From: Sagi Grimberg Message-ID: <7a49d9eb-2a46-dc8f-7284-b71c843cce8e@grimberg.me> Date: Mon, 5 Jun 2017 20:19:54 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170605114309.GA31824@dhcp-216.srv.tuxera.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 550 Lines: 16 > > V2: 1. Use cancel_work_sync instead of introducing new state (Sagi) > 2. Skip using NVME_CTRL_SCHED_RESET state (Sagi) > V1: nvme_probe set RESETTING state and check for NVME_CTRL_RESETTING > state in nvme_should_reset instead of work_busy (hch) This type of information should come after the '---' separator so git history won't keep it forever. > Fixes: c5f6ce97c1210 ("nvme: don't schedule multiple resets") > Signed-off-by: Rakesh Pandit > --- Other than that, Reviewed-by: Sagi Grimberg