Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751309AbdFEVae (ORCPT ); Mon, 5 Jun 2017 17:30:34 -0400 Received: from gateway36.websitewelcome.com ([192.185.193.119]:35866 "EHLO gateway36.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751195AbdFEVad (ORCPT ); Mon, 5 Jun 2017 17:30:33 -0400 Date: Mon, 5 Jun 2017 16:30:30 -0500 From: "Gustavo A. R. Silva" To: Stephen Hemminger , "David S. Miller" Cc: bridge@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] net: bridge: fix potential NULL pointer dereference Message-ID: <20170605213030.GA6272@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.175.0.156 X-Exim-ID: 1dHza2-000FlY-Vp X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedgus) [189.175.0.156]:54704 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 5 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 649 Lines: 23 Add NULL check before dereferencing pointer _p_ inside br_afspec(). Addresses-Coverity-ID: 1401872 Signed-off-by: Gustavo A. R. Silva --- net/bridge/br_netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c index 1e63ec4..ad85a9c 100644 --- a/net/bridge/br_netlink.c +++ b/net/bridge/br_netlink.c @@ -776,7 +776,7 @@ int br_setlink(struct net_device *dev, struct nlmsghdr *nlh, u16 flags) goto out; } - if (afspec) { + if (p && afspec) { err = br_afspec((struct net_bridge *)netdev_priv(dev), p, afspec, RTM_SETLINK); } -- 2.5.0