Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751489AbdFFHI2 (ORCPT ); Tue, 6 Jun 2017 03:08:28 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:45147 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751243AbdFFHIZ (ORCPT ); Tue, 6 Jun 2017 03:08:25 -0400 Date: Tue, 6 Jun 2017 00:07:57 -0700 From: Christoph Hellwig To: Adrian Hunter Cc: Vinayak Holikatti , "Martin K. Petersen" , "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Szymon Mielczarek , Michal Potomski , Grzegorz Janca Subject: Re: [PATCH 2/2] scsi: ufshcd-intel-pci: Add PCI driver for Intel Host controllers Message-ID: <20170606070757.GA1748@infradead.org> References: <1496651815-13416-1-git-send-email-adrian.hunter@intel.com> <1496651815-13416-3-git-send-email-adrian.hunter@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1496651815-13416-3-git-send-email-adrian.hunter@intel.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 494 Lines: 17 > +#define PCI_CLASS_STORAGE_UFSHCI 0x010901 should me move to pci_ids.h > + > +#define UFSHCD_INTEL_PCI_UFSHCI_DEVICE() { \ > + .vendor = PCI_VENDOR_ID_INTEL, \ > + .device = PCI_ANY_ID, \ > + .subvendor = PCI_ANY_ID, \ > + .subdevice = PCI_ANY_ID, \ > + .class = PCI_CLASS_STORAGE_UFSHCI, \ > + .class_mask = ~0, \ > +} Please don't use a macro for this. And matching for any possible future intel device with the classcode looks a little sketchy to me to be honest.