Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751292AbdFFIDG convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Tue, 6 Jun 2017 04:03:06 -0400
Received: from prv-mh.provo.novell.com ([137.65.248.74]:34435 "EHLO
        prv-mh.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751055AbdFFIDF (ORCPT
        <rfc822;groupwise-linux-kernel@vger.kernel.org:7:1>);
        Tue, 6 Jun 2017 04:03:05 -0400
Message-Id: <59367DD5020000780015FA35@prv-mh.provo.novell.com>
X-Mailer: Novell GroupWise Internet Agent 14.2.2 
Date: Tue, 06 Jun 2017 02:03:01 -0600
From: "Jan Beulich" <JBeulich@suse.com>
To: "Sergey Dyasli" <sergey.dyasli@citrix.com>
Cc: "Julien Grall" <julien.grall@arm.com>,
        "Marc Zyngier" <marc.zyngier@arm.com>,
        "Paul Durrant" <paul.durrant@citrix.com>,
        "Stefano Stabellini" <sstabellini@kernel.org>,
        <xen-devel@lists.xenproject.org>,
        "Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
        "Juergen Gross" <jgross@suse.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH v1] xen: fix HYPERVISOR_dm_op()
 prototype
References: <20170605084108.28844-1-sergey.dyasli@citrix.com>
In-Reply-To: <20170605084108.28844-1-sergey.dyasli@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1525
Lines: 44

>>> On 05.06.17 at 10:41, <sergey.dyasli@citrix.com> wrote:
> --- a/arch/x86/include/asm/xen/hypercall.h
> +++ b/arch/x86/include/asm/xen/hypercall.h
> @@ -49,6 +49,7 @@
>  #include <xen/interface/physdev.h>
>  #include <xen/interface/platform.h>
>  #include <xen/interface/xen-mca.h>
> +#include <xen/interface/hvm/dm_op.h>

Why?

> @@ -474,7 +475,7 @@ HYPERVISOR_xenpmu_op(unsigned int op, void *arg)
>  
>  static inline int
>  HYPERVISOR_dm_op(
> -	domid_t dom, unsigned int nr_bufs, void *bufs)
> +	domid_t dom, unsigned int nr_bufs, struct xen_dm_op_buf *bufs)

All you need above here is a forward declaration of the structure.
We should really avoid forcing source files to include all sorts of
headers without actually needing anything from them.

> --- a/include/xen/arm/hypercall.h
> +++ b/include/xen/arm/hypercall.h
> @@ -38,6 +38,7 @@
>  #include <xen/interface/xen.h>
>  #include <xen/interface/sched.h>
>  #include <xen/interface/platform.h>
> +#include <xen/interface/hvm/dm_op.h>

Same here.

> @@ -53,7 +54,8 @@ int HYPERVISOR_physdev_op(int cmd, void *arg);
>  int HYPERVISOR_vcpu_op(int cmd, int vcpuid, void *extra_args);
>  int HYPERVISOR_tmem_op(void *arg);
>  int HYPERVISOR_vm_assist(unsigned int cmd, unsigned int type);
> -int HYPERVISOR_dm_op(domid_t domid, unsigned int nr_bufs, void *bufs);
> +int HYPERVISOR_dm_op(domid_t domid, unsigned int nr_bufs,
> +		     struct xen_dm_op_buf *bufs);

How come you get away with changing a declaration without
also changing the matching definition?

Jan