Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751274AbdFFILK (ORCPT ); Tue, 6 Jun 2017 04:11:10 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:36513 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750805AbdFFILI (ORCPT ); Tue, 6 Jun 2017 04:11:08 -0400 Subject: Re: [PATCH 4.4 07/53] s390/qeth: add missing hash table initializations To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, Ursula Braun , "David S. Miller" References: <20170605153037.105331684@linuxfoundation.org> <20170605153037.439354686@linuxfoundation.org> From: Julian Wiedmann Date: Tue, 6 Jun 2017 10:11:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <20170605153037.439354686@linuxfoundation.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17060608-0008-0000-0000-0000045F3CB5 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17060608-0009-0000-0000-00001DE6FCF9 Message-Id: <095f194b-c9a6-a261-a9e8-9ada46e5d1fa@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-06_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706060149 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1461 Lines: 47 On 06/05/2017 06:17 PM, Greg Kroah-Hartman wrote: > 4.4-stable review patch. If anyone has any objections, please let me know. > Hi Greg, please drop this patch from the 4.4-stable queue, the commit that it fixes didn't exist in 4.4. git describe --contains 5f78e29ceebf v4.8-rc1~140^2~312^2~5 That also resolves the kbuild bot report for this patch. > ------------------ > > From: Ursula Braun > > > [ Upstream commit ebccc7397e4a49ff64c8f44a54895de9d32fe742 ] > > commit 5f78e29ceebf ("qeth: optimize IP handling in rx_mode callback") > added new hash tables, but missed to initialize them. > > Fixes: 5f78e29ceebf ("qeth: optimize IP handling in rx_mode callback") > Signed-off-by: Ursula Braun > Reviewed-by: Julian Wiedmann > Signed-off-by: Julian Wiedmann > Signed-off-by: David S. Miller > Signed-off-by: Greg Kroah-Hartman > --- > drivers/s390/net/qeth_l3_main.c | 2 ++ > 1 file changed, 2 insertions(+) > > --- a/drivers/s390/net/qeth_l3_main.c > +++ b/drivers/s390/net/qeth_l3_main.c > @@ -3232,6 +3232,8 @@ static int qeth_l3_probe_device(struct c > rc = qeth_l3_create_device_attributes(&gdev->dev); > if (rc) > return rc; > + hash_init(card->ip_htable); > + hash_init(card->ip_mc_htable); > card->options.layer2 = 0; > card->info.hwtrap = 0; > return 0; > >