Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751669AbdFFIy7 (ORCPT ); Tue, 6 Jun 2017 04:54:59 -0400 Received: from mail-by2nam03on0083.outbound.protection.outlook.com ([104.47.42.83]:12385 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751646AbdFFIyy (ORCPT ); Tue, 6 Jun 2017 04:54:54 -0400 From: Rafal Ozieblo To: Richard Cochran CC: David Miller , "nicolas.ferre@atmel.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "harini.katakam@xilinx.com" , "andrei.pistirica@microchip.com" Subject: RE: [PATCH v2 4/4] net: macb: Add hardware PTP support Thread-Topic: [PATCH v2 4/4] net: macb: Add hardware PTP support Thread-Index: AQHS26yCMIGfgNxtoESOPovh46jljaIVMmMAgAJa5SA= Date: Tue, 6 Jun 2017 08:54:50 +0000 Message-ID: References: <1496413439-12900-1-git-send-email-rafalo@cadence.com> <1496413690-22826-1-git-send-email-rafalo@cadence.com> <20170604205516.GA7848@localhost.localdomain> In-Reply-To: <20170604205516.GA7848@localhost.localdomain> Accept-Language: pl-PL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-ref: PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNccmFmYWxvXGFwcGRhdGFccm9hbWluZ1wwOWQ4NDliNi0zMmQzLTRhNDAtODVlZS02Yjg0YmEyOWUzNWJcbXNnc1xtc2ctY2FhMDM5M2YtNGE5NS0xMWU3LWJmNjAtMjhkMjQ0ZjNkMmFkXGFtZS10ZXN0XGNhYTAzOTQxLTRhOTUtMTFlNy1iZjYwLTI4ZDI0NGYzZDJhZGJvZHkudHh0IiBzej0iMTQ0MyIgdD0iMTMxNDEyMTI4ODc4NDEwMDcxIiBoPSJYanIvOEEvcEZRNEJJOXFBanJ1bmVkNE1NWU09IiBpZD0iIiBibD0iMCIgYm89IjEiLz48L21ldGE+ authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=cadence.com; x-originating-ip: [213.131.238.28] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BN3PR07MB2515;7:saPkq1x+tTS62vFPk7+wqWFTbo8x1+Z2UbEbvXJyRSYbb/hUNeq15wkQpLowymnyOWGz3C9wd/QjqIwm1vF6xke8JZVDRpxRrgxUqHZggGsdF4QG0wXO4gOYzfzGCS8aUVlZJq1TXmibnXZJxfyF+xvpM0wmUodJm3vfavdihlM6RAuPokkTOEhyQe0AIHZfwgedLKX6VITh1QbD2dcK4DSP/qjOGLabNh/XM2Qz58ytIG2kfZhm5ROyPRBnclnw1BuZkZhVvUKx06RALj9NiNCRvPX+g/cT8Z9pcD4Hg9GO2b+BOxfMbynNAxkFWvmo7CMUiqHsfq0aJs+7XA9j1Q==;20:qRGhI6PTSsMX4Ag/7A9QsLAeU8QzVS5y/+Vmb7Mm+7OPmU3PNccLwhd7T1FqW/w/Xx7nd2bWohHKU5LUBQQhXhmoFvBuQHfqZOGM0u+Uzt7lc7R/n82lYAlSM+okwDAf8T+nomyg3oWmR1Yy7uWmHh3UFriqBO33LegJwMG+D/juC31aD/gPAqLILuCrIUFHYBNyMZ8qUIn/ldoZT4e0QbjSyoPdCrl4ygbn6TUMCuGOce6cFPS58G4CHE9WXr6i x-ms-traffictypediagnostic: BN3PR07MB2515: x-ms-office365-filtering-correlation-id: 00a06b5c-e896-4c68-3955-08d4acb9b141 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(201703131423075)(201703031133081)(201702281549075);SRVR:BN3PR07MB2515; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(9452136761055)(258649278758335)(192813158149592)(72806322054110); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123562025)(20161123558100)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BN3PR07MB2515;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BN3PR07MB2515; x-forefront-prvs: 033054F29A x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39450400003)(39840400002)(39410400002)(39850400002)(39400400002)(36092001)(24454002)(6916009)(53546009)(2950100002)(77096006)(25786009)(122556002)(50986999)(39060400002)(4326008)(76176999)(54356999)(66066001)(7696004)(33656002)(8936002)(3280700002)(8676002)(81166006)(5660300001)(229853002)(2906002)(3660700001)(9686003)(189998001)(1411001)(6246003)(99286003)(54906002)(6436002)(8666007)(38730400002)(53936002)(2900100001)(110136004)(6506006)(14454004)(8656002)(55016002)(478600001)(86362001)(305945005)(6116002)(102836003)(7736002)(3846002)(74316002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR07MB2515;H:BN3PR07MB2516.namprd07.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: cadence.com X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jun 2017 08:54:50.6507 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR07MB2515 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v568tK7C001365 Content-Length: 1316 Lines: 43 > From: Richard Cochran [mailto:richardcochran@gmail.com] > Sent: 4 czerwca 2017 22:55 > To: Rafal Ozieblo > Cc: David Miller ; nicolas.ferre@atmel.com; > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > harini.katakam@xilinx.com; andrei.pistirica@microchip.com > Subject: Re: [PATCH v2 4/4] net: macb: Add hardware PTP support > > On Fri, Jun 02, 2017 at 03:28:10PM +0100, Rafal Ozieblo wrote: > > > +int gem_get_hwtst(struct net_device *dev, struct ifreq *rq) > > +{ > > + struct macb *bp = netdev_priv(dev); > > + struct hwtstamp_config *tstamp_config = &bp->tstamp_config; > > + > > + if ((bp->hw_dma_cap & HW_DMA_CAP_PTP) == 0) > > + return -EFAULT; > > Segmentation fault? Really? > > ... > > > +int gem_set_hwtst(struct net_device *dev, struct ifreq *ifr, int cmd) > > +{ > > + struct macb *bp = netdev_priv(dev); > > + struct hwtstamp_config *tstamp_config = &bp->tstamp_config; > > + enum macb_bd_control tx_bd_control = TSTAMP_DISABLED; > > + enum macb_bd_control rx_bd_control = TSTAMP_DISABLED; > > + u32 regval; > > + > > + if ((bp->hw_dma_cap & HW_DMA_CAP_PTP) == 0) > > + return -EFAULT; > > here again Would "ENOTSUP" be sufficient ? > > Thanks, > Richard Regards, Rafal