Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751484AbdFFJlt (ORCPT ); Tue, 6 Jun 2017 05:41:49 -0400 Received: from mga02.intel.com ([134.134.136.20]:9752 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751395AbdFFJlr (ORCPT ); Tue, 6 Jun 2017 05:41:47 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,305,1493708400"; d="asc'?scan'208";a="111422991" From: Felipe Balbi To: Greg KH Cc: Ruslan Bilovol , Alan Stern , Daniel Mack , Jassi Brar , Clemens Ladisch , Jonathan Corbet , Peter Chen , Julian Scheel , "linux-usb\@vger.kernel.org" , linux-doc@vger.kernel.org, "linux-kernel\@vger.kernel.org" Subject: Re: [PATCH v4 0/3] USB Audio Gadget refactoring In-Reply-To: <20170606074432.GA10232@kroah.com> References: <1495060654-31126-1-git-send-email-ruslan.bilovol@gmail.com> <87inkevi87.fsf@linux.intel.com> <87h8zuu6uy.fsf@linux.intel.com> <20170606074432.GA10232@kroah.com> Date: Tue, 06 Jun 2017 12:41:02 +0300 Message-ID: <87vao9sbbl.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2772 Lines: 68 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Greg KH writes: >> > I'm OK with dropping legacy f_uac1 implementation. >> > >> > Another idea I was thinking about is to implement simple in-kernel >> > driver which will do the same as existing alsaloop tool userspace >> > tool does (so legacy users will need to load two kernel modules >> > and get same functionality). But this seems to be a wrong way, >> > since It known that Linux kernel community doesn't like to take drivers >> > with same functionality as existing userspace tools already have. >> > >> > So bottom line: since I'm not a legacy f_uac1 user, there is no >> > difference for me how to handle it - remove legacy f_uac1 completely, >> > rename it to f_uac1_legacy or add separate f_uac1_acard function. >> > >> > So if dropping of legacy f_uac1 implementation is OK for you, >> > I can do it quickly in next patchset. >>=20 >> Personally, I don't want duplicated functionality and I think the >> virtual sound card approach is much better. Then again, removing >> functionality we already support is kind of odd. >>=20 >> Greg, Alan, what do you guys think? Do we keep a duplicated function >> around or do we just tell people to rely on alsaloop? Personally, I >> think we're better off with the flexibility of the virtual sound card, >> what's your take? > > If the in-kernel driver will do more things, and we don't break the > existing setups using alsaloop, then I don't see the problem, except > that we now have to maintain two things :) > > If you don't mind the maintenance, fine with me... Okay, I don't think many will continue to use f_uac1.c. Ruslan, can you update your series so that current f_uac1.c gets renamed to f_uac1_legacy.c and you introduce a *new* f_uac1.c instead? Thanks a lot =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlk2eK4ACgkQzL64meEa mQZpSg/8DIApeVdtW/BpxgW3ZLe+E7lkxM38DniAh1IOJZB7x61mox31mRLeYWGn /fxEoBeZ4LX4Cd5/dB2LlSBAlV7wGKVPOebB2msVrj4DngH33KRZPTM/NWNPTT9/ Vj5xxzRTf3crsMv7DnCGHffdbfnhGm6xxKLFug+VulOqFKYijJ5SMRgkyGIwQrkA rkalnMvtx8Hc6sNIMDscDu7mW4BkqOh40Kf07RukFpAgtJi0EBfdL97jU0aAIFXf 9U5GJyOqdyoC9ubWEv0Dq9A1AlLPLDxLM9z4KbOI5y+wDcw2SPsLOHuT3KG7tXhE MIMKF4dKkoHCcsHDG7UwtiLlycxvgL9DEXJckbfW/eru28YHfu63mz61Ttwt1Kuo /mTWTDQyOwohYYTcVKo0z/8N3EgkU37yAY1z/NqqxIuTIYXdk7RLpQv2AmCxReTD 3bn5lxzTmsnzHEUE9F3AtBCc8ck+D9NQD07s7PuzovK+fxSkXyddyyRwIpsXxErf 7KVejI1lRoS5WKJl6a9hq1LIW3vSc7SQJDeCKX6TFPD8MNcKwp9aKxO+w/uae0nm TElnXgtG0OVGJ04YofZW4Wkpoa5oP6Hmq6U1BWnFGpD/mA5ASre8srLeXWZfkQ5R qInjO2dudBCKYHF1e3a20MhLpCGhzUB/h2HhQWPr1RC+uYlg0j8= =HK9V -----END PGP SIGNATURE----- --=-=-=--