Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751615AbdFFJnY (ORCPT ); Tue, 6 Jun 2017 05:43:24 -0400 Received: from smtp.ctxuk.citrix.com ([185.25.65.24]:45390 "EHLO SMTP.EU.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751435AbdFFJnX (ORCPT ); Tue, 6 Jun 2017 05:43:23 -0400 X-IronPort-AV: E=Sophos;i="5.39,305,1493683200"; d="scan'208";a="47273286" From: Sergey Dyasli To: "JBeulich@suse.com" CC: "boris.ostrovsky@oracle.com" , "linux-kernel@vger.kernel.org" , "sstabellini@kernel.org" , Paul Durrant , Sergey Dyasli , "jgross@suse.com" , "marc.zyngier@arm.com" , "xen-devel@lists.xenproject.org" , "julien.grall@arm.com" Subject: Re: [Xen-devel] [PATCH v1] xen: fix HYPERVISOR_dm_op() prototype Thread-Topic: [Xen-devel] [PATCH v1] xen: fix HYPERVISOR_dm_op() prototype Thread-Index: AQHS3deL0gLFhinz8E+5M0WUqFri/qIXWWyAgAAcBwA= Date: Tue, 6 Jun 2017 09:43:20 +0000 Message-ID: <1496742200.2797.1.camel@citrix.com> References: <20170605084108.28844-1-sergey.dyasli@citrix.com> <59367DD5020000780015FA35@prv-mh.provo.novell.com> In-Reply-To: <59367DD5020000780015FA35@prv-mh.provo.novell.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.22.6-1ubuntu1 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v569hkrW006447 Content-Length: 1814 Lines: 53 On Tue, 2017-06-06 at 02:03 -0600, Jan Beulich wrote: > > > > On 05.06.17 at 10:41, wrote: > > > > --- a/arch/x86/include/asm/xen/hypercall.h > > +++ b/arch/x86/include/asm/xen/hypercall.h > > @@ -49,6 +49,7 @@ > > #include > > #include > > #include > > +#include > > Why? > > > @@ -474,7 +475,7 @@ HYPERVISOR_xenpmu_op(unsigned int op, void *arg) > > > > static inline int > > HYPERVISOR_dm_op( > > - domid_t dom, unsigned int nr_bufs, void *bufs) > > + domid_t dom, unsigned int nr_bufs, struct xen_dm_op_buf *bufs) > > All you need above here is a forward declaration of the structure. > We should really avoid forcing source files to include all sorts of > headers without actually needing anything from them. Thank you for the good suggestion. I will fix this in v2. > > > --- a/include/xen/arm/hypercall.h > > +++ b/include/xen/arm/hypercall.h > > @@ -38,6 +38,7 @@ > > #include > > #include > > #include > > +#include > > Same here. > > > @@ -53,7 +54,8 @@ int HYPERVISOR_physdev_op(int cmd, void *arg); > > int HYPERVISOR_vcpu_op(int cmd, int vcpuid, void *extra_args); > > int HYPERVISOR_tmem_op(void *arg); > > int HYPERVISOR_vm_assist(unsigned int cmd, unsigned int type); > > -int HYPERVISOR_dm_op(domid_t domid, unsigned int nr_bufs, void *bufs); > > +int HYPERVISOR_dm_op(domid_t domid, unsigned int nr_bufs, > > + struct xen_dm_op_buf *bufs); > > How come you get away with changing a declaration without > also changing the matching definition? The definition of HYPERVISOR_dm_op() is in arch/arm/xen/hypercall.S -- Thanks, Sergey