Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751426AbdFFKJA (ORCPT ); Tue, 6 Jun 2017 06:09:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60824 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751274AbdFFKI6 (ORCPT ); Tue, 6 Jun 2017 06:08:58 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A2CDA81F01 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dhowells@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A2CDA81F01 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20170606005108.5646-6-Jason@zx2c4.com> References: <20170606005108.5646-6-Jason@zx2c4.com> <20170606005108.5646-1-Jason@zx2c4.com> To: "Jason A. Donenfeld" Cc: dhowells@redhat.com, "Theodore Ts'o" , Linux Crypto Mailing List , LKML , kernel-hardening@lists.openwall.com, Greg Kroah-Hartman , David Miller , Mimi Zohar , David Safford Subject: Re: [PATCH v3 05/13] security/keys: ensure RNG is seeded before use MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <26641.1496743729.1@warthog.procyon.org.uk> Date: Tue, 06 Jun 2017 11:08:49 +0100 Message-ID: <26642.1496743729@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 06 Jun 2017 10:08:53 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 140 Lines: 7 Jason A. Donenfeld wrote: > + key->serial = get_random_u32() >> 1; If this may sleep, it must be interruptible. David