Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751448AbdFFKKj (ORCPT ); Tue, 6 Jun 2017 06:10:39 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:47522 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751330AbdFFKKi (ORCPT ); Tue, 6 Jun 2017 06:10:38 -0400 Date: Tue, 6 Jun 2017 03:10:34 -0700 From: Christoph Hellwig To: Adrian Hunter Cc: Vinayak Holikatti , "Martin K. Petersen" , Christoph Hellwig , "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Szymon Mielczarek , Michal Potomski , Grzegorz Janca Subject: Re: [PATCH V3 2/2] scsi: ufshcd-intel-pci: Add PCI driver for Intel Host controllers Message-ID: <20170606101034.GA20599@infradead.org> References: <20170606070757.GA1748@infradead.org> <1496740136-4024-1-git-send-email-adrian.hunter@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1496740136-4024-1-git-send-email-adrian.hunter@intel.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 379 Lines: 9 This looks much better. But the new file still looks almost like a copy and paste of tc-dwc-g210-pci.c. Wouldnt it make more sense to start with a common ufshcd-pci driver that sets up the ufs_hba_variant_opsA based on the PCI ID table? Also given that this almost entitrely a copy & paste job of tc-dwc-g210-pci.c. you should add the copyrights and following their license.