Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751506AbdFFL1o (ORCPT ); Tue, 6 Jun 2017 07:27:44 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:41692 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751305AbdFFL1m (ORCPT ); Tue, 6 Jun 2017 07:27:42 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 06 Jun 2017 16:57:40 +0530 From: kgunda@codeaurora.org To: Stephen Boyd Cc: Abhijeet Dharmapurikar , David Collins , Christophe JAILLET , Subbaraman Narayanamurthy , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, adharmap@quicinc.com, aghayal@qti.qualcomm.com, linux-arm-msm-owner@vger.kernel.org Subject: Re: [PATCH V1 14/15] spmi: pmic-arb: do not ack and clear peripheral interrupts in cleanup_irq In-Reply-To: References: <1496147943-25822-1-git-send-email-kgunda@codeaurora.org> <1496147943-25822-15-git-send-email-kgunda@codeaurora.org> <20170531175330.GE20170@codeaurora.org> Message-ID: <644a2fd1dc36c3fd4ee5cd7f835c41a9@codeaurora.org> User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1784 Lines: 36 On 2017-06-02 12:56, kgunda@codeaurora.org wrote: > On 2017-05-31 23:23, Stephen Boyd wrote: >> On 05/30, Kiran Gunda wrote: >>> From: Subbaraman Narayanamurthy >>> >>> Currently, cleanup_irq() is invoked when a peripheral's interrupt >>> fires and there is no mapping present in the interrupt domain of >>> spmi interrupt controller. >>> >>> The cleanup_irq clears the arbiter bit, clears the pmic interrupt >>> and disables it at the pmic in that order. The last disable in >>> cleanup_irq races with request_irq() in that it stomps over the >>> enable issued by request_irq. Fix this by not writing to the pmic >>> in cleanup_irq. The latched bit will be left set in the pmic, >>> which will not send us more interrupts even if the enable bit >>> stays enabled. >>> >>> When a client wants to request an interrupt, use the activate >>> callback on the irq_domain to clear latched bit. This ensures >>> that the latched, if set due to the above changes in cleanup_irq >>> or when the bootloader leaves it set, gets cleaned up, paving way >>> for upcoming interrupts to trigger. >>> >>> With this, there is a possibility of unwanted triggering of >>> interrupt right after the latched bit is cleared - the interrupt >>> may be left enabled too. To avoid that, clear the enable first >>> followed by clearing the latched bit in the activate callback. >>> >>> Signed-off-by: Subbaraman Narayanamurthy >>> Signed-off-by: Kiran Gunda >> >> Please squash this with the patch that adds cleanup_irq() and >> rewrite the commit text to combine details from both. > Sure. Will squash it in the next patch submission. Patch that adds cleanup_irq is already taken in to the tree. Lets have this patch as is now.