Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751642AbdFFMtT (ORCPT ); Tue, 6 Jun 2017 08:49:19 -0400 Received: from mail-ot0-f196.google.com ([74.125.82.196]:36144 "EHLO mail-ot0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751499AbdFFMtR (ORCPT ); Tue, 6 Jun 2017 08:49:17 -0400 MIME-Version: 1.0 In-Reply-To: <20170603141515.9529-2-asarai@suse.de> References: <20170603141515.9529-1-asarai@suse.de> <20170603141515.9529-2-asarai@suse.de> From: Arnd Bergmann Date: Tue, 6 Jun 2017 14:49:15 +0200 X-Google-Sender-Auth: AIGo9HK52MW2xusMwko77acbauY Message-ID: Subject: Re: [PATCH v4 1/2] tty: add compat_ioctl callbacks To: Aleksa Sarai Cc: Greg Kroah-Hartman , Jiri Slaby , Linux Kernel Mailing List , linux-alpha@vger.kernel.org, "open list:RALINK MIPS ARCHITECTURE" , Parisc List , linuxppc-dev , linux-sh@vger.kernel.org, sparclinux , linux-xtensa@linux-xtensa.org, linux-arch , Christian Brauner , Valentin Rothberg Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 479 Lines: 12 On Sat, Jun 3, 2017 at 4:15 PM, Aleksa Sarai wrote: > In order to avoid future diversions between fs/compat_ioctl.c and > drivers/tty/pty.c, define .compat_ioctl callbacks for the relevant > tty_operations structs. Since both pty_unix98_ioctl() and > pty_bsd_ioctl() are compatible between 32-bit and 64-bit userspace no > special translation is required. > > Signed-off-by: Aleksa Sarai Looks good, Reviewed-by: Arnd Bergmann