Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751452AbdFFN3F (ORCPT ); Tue, 6 Jun 2017 09:29:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49020 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751384AbdFFN3D (ORCPT ); Tue, 6 Jun 2017 09:29:03 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9E8F44E4D3 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=rkrcmar@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 9E8F44E4D3 Date: Tue, 6 Jun 2017 15:28:58 +0200 From: Radim Krcmar To: Wanpeng Li Cc: Paolo Bonzini , "linux-kernel@vger.kernel.org" , kvm , ross.zwisler@linux.intel.com, "Paul E. McKenney" , jack@suse.cz, linux-ext4@vger.kernel.org, tytso@mit.edu, Josh Triplett , "# v3 . 10+" Subject: Re: [PATCH] kvm: async_pf: fix rcu_irq_enter() with irqs enabled Message-ID: <20170606132857.GB10167@potion> References: <20170426145626.6407-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 06 Jun 2017 13:29:02 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 640 Lines: 18 2017-06-05 12:21+0800, Wanpeng Li: > 2017-04-26 22:56 GMT+08:00 Paolo Bonzini : > > native_safe_halt enables interrupts, and you just shouldn't > > call rcu_irq_enter() with interrupts enabled. Reorder the > > call with the following local_irq_disable() to respect the > > invariant. > > > > Reported-by: Ross Zwisler > > Cc: stable@vger.kernel.org > > Signed-off-by: Paolo Bonzini > > I'm afraid we miss this commit. This commit can fix the below warning Applied to kvm/master, > Tested-by: Wanpeng Li thanks for the testing and ping!