Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751501AbdFFNu2 (ORCPT ); Tue, 6 Jun 2017 09:50:28 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:34744 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751451AbdFFNu0 (ORCPT ); Tue, 6 Jun 2017 09:50:26 -0400 Date: Tue, 6 Jun 2017 14:50:17 +0100 From: Lee Jones To: Guodong Xu Cc: robh+dt@kernel.org, mark.rutland@arm.com, xuwei5@hisilicon.com, catalin.marinas@arm.com, will.deacon@arm.com, lgirdwood@gmail.com, broonie@kernel.org, khilman@baylibre.com, arnd@arndb.de, gregory.clement@free-electrons.com, horms+renesas@verge.net.au, olof@lixom.net, thomas.petazzoni@free-electrons.com, yamada.masahiro@socionext.com, riku.voipio@linaro.org, treding@nvidia.com, krzk@kernel.org, eric@anholt.net, damm+renesas@opensource.se, ard.biesheuvel@linaro.org, linus.walleij@linaro.org, geert+renesas@glider.be, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, hw.wangxiaoyin@hisilicon.com Subject: Re: [PATCH v4 2/8] mfd: hi6421-pmic: cleanup: update dev_err messages Message-ID: <20170606135017.gwdyrcof5iqvtlw5@dell> References: <20170606085143.13154-1-guodong.xu@linaro.org> <20170606085143.13154-3-guodong.xu@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170606085143.13154-3-guodong.xu@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1469 Lines: 42 On Tue, 06 Jun 2017, Guodong Xu wrote: > Update dev_err messages to make them more readable. > > Signed-off-by: Guodong Xu > --- > drivers/mfd/hi6421-pmic-core.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) For my own reference: Acked-for-MFD-by: Lee Jones > diff --git a/drivers/mfd/hi6421-pmic-core.c b/drivers/mfd/hi6421-pmic-core.c > index ad9e3d8..b1139d4 100644 > --- a/drivers/mfd/hi6421-pmic-core.c > +++ b/drivers/mfd/hi6421-pmic-core.c > @@ -52,8 +52,8 @@ static int hi6421_pmic_probe(struct platform_device *pdev) > pmic->regmap = devm_regmap_init_mmio_clk(&pdev->dev, NULL, base, > &hi6421_regmap_config); > if (IS_ERR(pmic->regmap)) { > - dev_err(&pdev->dev, > - "regmap init failed: %ld\n", PTR_ERR(pmic->regmap)); > + dev_err(&pdev->dev, "Failed to initialise Regmap: %ld\n", > + PTR_ERR(pmic->regmap)); > return PTR_ERR(pmic->regmap); > } > > @@ -70,7 +70,7 @@ static int hi6421_pmic_probe(struct platform_device *pdev) > ret = devm_mfd_add_devices(&pdev->dev, 0, hi6421_devs, > ARRAY_SIZE(hi6421_devs), NULL, 0, NULL); > if (ret) { > - dev_err(&pdev->dev, "add mfd devices failed: %d\n", ret); > + dev_err(&pdev->dev, "Failed to add child devices: %d\n", ret); > return ret; > } > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog