Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751619AbdFFOYv (ORCPT ); Tue, 6 Jun 2017 10:24:51 -0400 Received: from mga11.intel.com ([192.55.52.93]:46436 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751593AbdFFOYs (ORCPT ); Tue, 6 Jun 2017 10:24:48 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,306,1493708400"; d="scan'208";a="95208806" Subject: Re: [PATCH v3] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge. To: Archit Taneja , Eric Anholt , Andrzej Hajda , Laurent Pinchart , Thierry Reding Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20170602202514.11900-1-eric@anholt.net> <2ab4e84f-9834-1dce-d16a-14f9cc4083e9@codeaurora.org> From: Maarten Lankhorst Message-ID: <2cbcbf54-debf-10a1-390d-128171d81f91@linux.intel.com> Date: Tue, 6 Jun 2017 16:24:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <2ab4e84f-9834-1dce-d16a-14f9cc4083e9@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1760 Lines: 37 Op 05-06-17 om 12:08 schreef Archit Taneja: > > > On 06/03/2017 01:55 AM, Eric Anholt wrote: >> Many DRM drivers have common code to make a stub connector >> implementation that wraps a drm_panel. By wrapping the panel in a DRM >> bridge, all of the connector code (including calls during encoder >> enable/disable) goes away. >> >> v2: Fix build with CONFIG_DRM=m, drop "dev" argument that should just >> be the panel's dev, move kerneldoc up a level and document >> _remove(). >> v3: Fix another breakage with CONFIG_DRM=m, fix breakage with >> CONFIG_OF=n, move protos under CONFIG_DRM_PANEL_BRIDGE, wrap a >> line. >> >> Signed-off-by: Eric Anholt >> Acked-by: Daniel Vetter (v1) >> Reviewed-by: Boris Brezillon (v2) >> Acked-by: Archit Taneja (v2) >> --- >> >> New version of the first patch with build fixes. I've re-pushed to >> get another round of kbuild test, but if it comes back clean, I'd like >> to merge this one, the vc4 patches (unchanged), and atmel-hlcdc (acked >> by the maintainer). I'd be dropping my STM patch (replaced by their >> DSI series), and mediatek (I'd like an ack from the maintainer first). > > Thanks, I've locally picked up this patch and the following patches from > the v2 series: > > [PATCH v2 2/7] drm/vc4: Switch DSI to the panel-bridge layer, and support bridges. > [PATCH v2 3/7] drm/vc4: Switch DPI to using the panel-bridge helper. > [PATCH v2 6/7] drm/atmel-hlcdc: Drop custom encoder cleanup func. > [PATCH v2 7/7] drm/atmel-hlcdc: Replace the panel usage with drm_panel_bridge. This patch breaks support for building drm as module, because it imports some of the drm_kms_helper stuff.