Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263271AbTFGQqY (ORCPT ); Sat, 7 Jun 2003 12:46:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263275AbTFGQqY (ORCPT ); Sat, 7 Jun 2003 12:46:24 -0400 Received: from hermes.fachschaften.tu-muenchen.de ([129.187.202.12]:60882 "HELO hermes.fachschaften.tu-muenchen.de") by vger.kernel.org with SMTP id S263271AbTFGQqW (ORCPT ); Sat, 7 Jun 2003 12:46:22 -0400 Date: Sat, 7 Jun 2003 18:59:51 +0200 From: Adrian Bunk To: Bartlomiej Zolnierkiewicz , bcollins@debian.org, linux1394-devel@lists.sourceforge.net Cc: Jean Tourrilhes , linux-net@vger.kernel.org, linux-kernel@vger.kernel.org, trivial@rustcorp.com.au Subject: Re: [patch] fix vlsi_ir.c compile if !CONFIG_PROC_FS Message-ID: <20030607165951.GA13377@fs.tum.de> References: <20030607152434.GQ15311@fs.tum.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1612 Lines: 43 On Sat, Jun 07, 2003 at 06:22:39PM +0200, Bartlomiej Zolnierkiewicz wrote: > > Apply something like this: > > --- linux-2.5.70-bk11/include/proc_fs.h Fri Jun 6 18:43:49 2003 > +++ linux/include/proc_fs.h Sat Jun 7 18:11:22 2003 > @@ -205,7 +205,7 @@ > static inline struct proc_dir_entry *create_proc_entry(const char *name, > mode_t mode, struct proc_dir_entry *parent) { return NULL; } > > -static inline void remove_proc_entry(const char *name, struct proc_dir_entry *parent) {}; > +#define remove_proc_entry(name, parent) /* nothing */ > static inline struct proc_dir_entry *proc_symlink(const char *name, > struct proc_dir_entry *parent,char *dest) {return NULL;} > static inline struct proc_dir_entry *proc_mknod(const char *name,mode_t mode, > > And you wil not have to readd #ifdef/#endif pair. > > I've seen Sam's mail but this is generic solution to quiet compiler > and will work for any remove_proc_entry() user. Yup, for this specific error Sam's solution is the best one, but your patch e.g. solves the ieee1394_core.c compile error I reported, too. > Thanks, > -- > Bartlomiej cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/