Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751510AbdFFPXK (ORCPT ); Tue, 6 Jun 2017 11:23:10 -0400 Received: from frisell.zx2c4.com ([192.95.5.64]:36875 "EHLO frisell.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751390AbdFFPXJ (ORCPT ); Tue, 6 Jun 2017 11:23:09 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170606005108.5646-1-Jason@zx2c4.com> <20170606005108.5646-5-Jason@zx2c4.com> <20170606030004.4go6btmobrsmqiwz@thunk.org> <20170606044404.GA3469@zzz> From: "Jason A. Donenfeld" Date: Tue, 6 Jun 2017 17:23:04 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [kernel-hardening] Re: [PATCH v3 04/13] crypto/rng: ensure that the RNG is ready before using To: Eric Biggers , David Howells Cc: "Theodore Ts'o" , Linux Crypto Mailing List , LKML , kernel-hardening@lists.openwall.com, Greg Kroah-Hartman , David Miller , Herbert Xu , Stephan Mueller Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 669 Lines: 18 Hey again Eric, One thing led to another and I wound up just rewriting all the crypto in big_keys.c. I'll include this for v4: https://git.zx2c4.com/linux-dev/commit/?h=jd/rng-blocker&id=886ff283b9808aecb14aa8e397da8496a9635aed Not only was the use of crypto/rng inappropriate, but the decision to go with aes-ecb is shocking. Seeing that this author had no other commits in the tree, and that all subsequent commits that mentioned his name were cleaning up his mess, I just went ahead and removed both the crypto/rng misusage and changed from aes-ecb to aes-gcm. Anyway, I'll wait for some more reviews on v3, and then this can be reviewed for v4. Regards, Jason