Date: Tue, 6 Jun 2017 17:39:07 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: David Kershner <david.kershner@unisys.com>,
        Andy Whitcroft <apw@canonical.com>, corbet@lwn.net, tglx@linutronix.de,
        mingo@kernel.org, akpm@linux-foundation.org, jes.sorensen@gmail.com,
        linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
        driverdev-devel@linuxdriverproject.org, sparmaintainer@unisys.com
Subject: Re: [PATCH 0/3] move visorbus out of staging to drivers/virt/visorbus
Message-ID: <20170606153907.GA3243@kroah.com>
References: <1496693252-4349-1-git-send-email-david.kershner@unisys.com>
 <20170606144909.GA31938@kroah.com>
 <20170606145322.GA32397@kroah.com>
 <1496763229.1968.20.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1496763229.1968.20.camel@perches.com>
User-Agent: Mutt/1.8.3 (2017-05-23)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1417
Lines: 46

On Tue, Jun 06, 2017 at 08:33:49AM -0700, Joe Perches wrote:
> On Tue, 2017-06-06 at 16:53 +0200, Greg KH wrote:
> > On Tue, Jun 06, 2017 at 04:49:09PM +0200, Greg KH wrote:
> > > I noticed that in drivers/staging/unisys/visorbus/visorbus_main.c, you
> > > have 2 tabs for your 'struct attribute' variables, which is really odd.
> []
> > Also, many of the attribute callbacks in that file seem to all have
> > their leading '{' in the wrong place.  Odd that checkpatch.pl doesn't
> > catch that...
> 
> checkpatch doesn't really check much about inconsistent
> indentation.  I believe the only new statement indentation
> check is after an if.
> 
> For instance, checkpatch doesn't emit a warning on this code:
> 
> struct foo {
> 		int bar;
> };
> 
> struct foo *alloc_foo(void)
> {
> 			struct foo *baz = malloc(sizeof(struct foo));
> 		if (baz)
> 			baz->bar = 1;
> 				return baz;
> }

Ok, but the following code in that file should be caught, right:

static ssize_t partition_handle_show(struct device *dev,
                                     struct device_attribute *attr,
                                     char *buf) {
        struct visor_device *vdev = to_visor_device(dev);
        u64 handle = visorchannel_get_clientpartition(vdev->visorchannel);

        return sprintf(buf, "0x%llx\n", handle);
}
static DEVICE_ATTR_RO(partition_handle);


The initial { is in the wrong place...

thanks,

greg k-h