Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751489AbdFFPwW (ORCPT ); Tue, 6 Jun 2017 11:52:22 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:43958 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751388AbdFFPwV (ORCPT ); Tue, 6 Jun 2017 11:52:21 -0400 Date: Tue, 6 Jun 2017 17:52:19 +0200 From: Thomas Petazzoni To: Mason Cc: Marc Zyngier , Thomas Gleixner , Jason Cooper , Mark Rutland , Thibaud Cornic , LKML , Linux ARM Subject: Re: [RFC PATCH v1] irqchip: Add support for tango interrupt router Message-ID: <20170606175219.34ef62b9@free-electrons.com> In-Reply-To: <657580dd-0cfe-e377-e425-0deabf6d20c3@free.fr> References: <657580dd-0cfe-e377-e425-0deabf6d20c3@free.fr> Organization: Free Electrons X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 880 Lines: 36 Hello, On Tue, 6 Jun 2017 15:42:36 +0200, Mason wrote: > + interrupt-controller@6f800 { > + compatible = "sigma,smp8759-intc"; > + reg = <0x6f800 0x430>; > + interrupt-controller; > + #interrupt-cells = <2>; > + interrupt-parent = <&gic>; > + /* > + * There probably is a better way than explicitly listing > + * the 24 interrupts? > + */ What we do on Marvell platforms is: marvell,spi-base = <128>, <136>, <144>, <152>; see marvell,odmi-controller.txt. In another driver I submitted, we're doing: marvell,spi-ranges = <64 64>, <288 64>; Retrospectively, I would have preferred to use marvell,spi-ranges for the first DT binding as well, since it allows to express both the base and number of interrupts available in the range. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com