Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751810AbdFFQEL (ORCPT ); Tue, 6 Jun 2017 12:04:11 -0400 Received: from mail-ua0-f173.google.com ([209.85.217.173]:35069 "EHLO mail-ua0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751677AbdFFQEI (ORCPT ); Tue, 6 Jun 2017 12:04:08 -0400 MIME-Version: 1.0 In-Reply-To: <20170606030302.GC27270@fury> References: <20170601204339.GA1842@kmp-mobile.hq.kempniu.pl> <20170606030302.GC27270@fury> From: Andy Lutomirski Date: Tue, 6 Jun 2017 09:03:41 -0700 Message-ID: Subject: Re: [PATCH 09/16] platform/x86: wmi: Instantiate all devices before adding them To: Darren Hart Cc: =?UTF-8?B?TWljaGHFgiBLxJlwaWXFhA==?= , platform-driver-x86@vger.kernel.org, Andy Shevchenko , Andy Lutomirski , Mario Limonciello , =?UTF-8?Q?Pali_Roh=C3=A1r?= , Rafael Wysocki , "linux-kernel@vger.kernel.org" , Linux ACPI Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v56G4EoC004376 Content-Length: 926 Lines: 19 On Mon, Jun 5, 2017 at 8:03 PM, Darren Hart wrote: > On Thu, Jun 01, 2017 at 10:43:39PM +0200, Michał Kępień wrote: >> I know I have probably started sounding like a broken record by now, but >> I still have not seen any response (apart from the typos getting fixed) >> to my comments on this patch which I posted in January 2016 [1]. >> >> None of the issues I found back then are really critical, but I did >> point out a potential memory leak (granted, an unlikely one), so it >> might be a good idea to at least take a second look before merging. >> >> [1] https://www.spinics.net/lists/platform-driver-x86/msg08201.html > > Thanks for being persistent, some good points in there. I'd like to just squash > these into this patch (9/16), but I'll include them here for an ack from you and > Andy L. that this is what you meant, and consistent with his > intent/understanding: > Looks good to me.