Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751521AbdFFQWy (ORCPT ); Tue, 6 Jun 2017 12:22:54 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:33796 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751431AbdFFQWw (ORCPT ); Tue, 6 Jun 2017 12:22:52 -0400 Date: Tue, 06 Jun 2017 12:22:50 -0400 (EDT) Message-Id: <20170606.122250.1431459979681086413.davem@davemloft.net> To: colin.king@canonical.com Cc: yotamg@mellanox.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][net-next] net/mlxfw: remove redundant goto on error check From: David Miller In-Reply-To: <20170606104740.15712-1-colin.king@canonical.com> References: <20170606104740.15712-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 06 Jun 2017 08:41:13 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 471 Lines: 15 From: Colin King Date: Tue, 6 Jun 2017 11:47:40 +0100 > From: Colin Ian King > > The check to see of err is set and the subsequent goto is extraneous > as the next statement is where the goto is jumping to. Remove this > redundant check and goto. > > Detected by CoverityScan, CID#1437734 ("Identical code for > different branches") > > Signed-off-by: Colin Ian King Applied, thanks.