MIME-Version: 1.0
In-Reply-To: <CAK8P3a3nrxvTVx8zjgf+_byAX82FG8jFD73L2nPSJBwK5grdXA@mail.gmail.com>
References: <20170530181306.GV141096@google.com> <20170531235519.GX141096@google.com>
 <CAK8P3a3nrxvTVx8zjgf+_byAX82FG8jFD73L2nPSJBwK5grdXA@mail.gmail.com>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Tue, 6 Jun 2017 09:32:35 -0700
Message-ID: <CA+55aFyhgWGr-=9t7131XAUyNy8Zs_vUfp-PGu_eaLkMAa6=sg@mail.gmail.com>
Subject: Re: [RFC] clang: 'unused-function' warning on static inline functions
To: Arnd Bergmann <arnd@arndb.de>
Cc: Matthias Kaehlcke <mka@chromium.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Ingo Molnar <mingo@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
        Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
        Steven Rostedt <rostedt@goodmis.org>,
        David Rientjes <rientjes@google.com>,
        Douglas Anderson <dianders@chromium.org>,
        Guenter Roeck <linux@roeck-us.net>, Mark Brown <broonie@kernel.org>,
        David Miller <davem@davemloft.net>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 650
Lines: 17

On Tue, Jun 6, 2017 at 4:16 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>
> Those should all be fairly easy to address, I'd vote for leaving the
> warning enabled
> in clang, and possibly asking the gcc maintainers to add a similar feature for
> warning about it.

Hell no. That warning is pointless shit.

The function is inlined. If it's not used, why the f*ck should you get
a warning? Just to add more pointless #ifdef'fery around a function
that is perhaps only used under certain circumstances?

No. That warning is garbage, and we will ignore it, and we sure as
hell will not ask gcc to add more garbage warnings.

                         Linus