Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751623AbdFFRCF (ORCPT ); Tue, 6 Jun 2017 13:02:05 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:60619 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751600AbdFFRCD (ORCPT ); Tue, 6 Jun 2017 13:02:03 -0400 Date: Tue, 6 Jun 2017 10:02:01 -0700 From: Darren Hart To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Andy Lutomirski , platform-driver-x86@vger.kernel.org, Andy Shevchenko , Andy Lutomirski , Mario Limonciello , Rafael Wysocki , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v2] platform/x86: wmi-bmof: New driver to expose embedded Binary WMI MOF metadata Message-ID: <20170606170201.GC32509@fury> References: <20170606100440.GA4690@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170606100440.GA4690@pali> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 580 Lines: 16 On Tue, Jun 06, 2017 at 12:04:40PM +0200, Pali Roh?r wrote: > On Monday 05 June 2017 20:16:44 Andy Lutomirski wrote: > > +#define WMI_BMOF_GUID "05901221-D566-11D1-B2F0-00A0C9062910" > > +MODULE_ALIAS("wmi:" WMI_BMOF_GUID); > > Cannot we generate MODULE_ALIAS from module_wmi_driver()? IIRC it is > working for i2c drivers. I could see this being automated since we always use wmi:GUID, but it isn't currently. Happy to consider it as a follow on. Do you have a specific i2c example you think we should consider following? -- Darren Hart VMware Open Source Technology Center