Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751607AbdFFSlg (ORCPT ); Tue, 6 Jun 2017 14:41:36 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33396 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751426AbdFFSjj (ORCPT ); Tue, 6 Jun 2017 14:39:39 -0400 Date: Tue, 6 Jun 2017 20:39:33 +0200 From: Richard Cochran To: Rafal Ozieblo Cc: David Miller , nicolas.ferre@atmel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, harini.katakam@xilinx.com, andrei.pistirica@microchip.com Subject: Re: [PATCH v2 3/4] net: macb: macb.c changed to macb_main.c Message-ID: <20170606183933.GA1205@localhost.localdomain> References: <1496413439-12900-1-git-send-email-rafalo@cadence.com> <1496413661-21452-1-git-send-email-rafalo@cadence.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1496413661-21452-1-git-send-email-rafalo@cadence.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 676 Lines: 22 On Fri, Jun 02, 2017 at 03:27:41PM +0100, Rafal Ozieblo wrote: > drivers/net/ethernet/cadence/macb.c | 3568 ------------------------------ > drivers/net/ethernet/cadence/macb_main.c | 3568 ++++++++++++++++++++++++++++++ You deleted macb.c, and so ... > diff --git a/drivers/net/ethernet/cadence/Makefile b/drivers/net/ethernet/cadence/Makefile > index 4ba7559..31ea6e3 100644 > --- a/drivers/net/ethernet/cadence/Makefile > +++ b/drivers/net/ethernet/cadence/Makefile > @@ -1,6 +1,7 @@ > # > # Makefile for the Atmel network device drivers. > # > +macb-y := macb_main.o > > obj-$(CONFIG_MACB) += macb.o how does this rule make sense any more? Thanks, Richard