Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751531AbdFFS5r (ORCPT ); Tue, 6 Jun 2017 14:57:47 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:58464 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751247AbdFFS5q (ORCPT ); Tue, 6 Jun 2017 14:57:46 -0400 Date: Tue, 6 Jun 2017 19:57:30 +0100 From: Mark Brown To: Leilk Liu Cc: Mark Rutland , Matthias Brugger , Sascha Hauer , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-mediatek@lists.infradead.org, sean.wang@mediatek.com Message-ID: <20170606185730.mrvgvp4hynftwahx@sirena.org.uk> References: <1496387923-31674-1-git-send-email-leilk.liu@mediatek.com> <1496387923-31674-3-git-send-email-leilk.liu@mediatek.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="s5q23k2nvqkztuhz" Content-Disposition: inline In-Reply-To: <1496387923-31674-3-git-send-email-leilk.liu@mediatek.com> X-Cookie: The heart is wiser than the intellect. User-Agent: NeoMutt/20170306 (1.8.0) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 2/3] spi: mediatek: support adjust register define X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1020 Lines: 32 --s5q23k2nvqkztuhz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jun 02, 2017 at 03:18:42PM +0800, Leilk Liu wrote: > + /* some IC design adjust register define */ > + bool adjust_reg; Can we have a name that's more specific to the particular quirk please? The current name will get confusing if some future chip also needs slightly different register settings. Otherwise this looks good. --s5q23k2nvqkztuhz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlk2+xkACgkQJNaLcl1U h9Cglgf/QmdHkkLNKqhxHzwztZYbtNDf6seGxLmC59VRyYAkFnKRKoCdibGw8OO5 fRJiYTQ4GL0EcfVkNzC9RE39MLzsw8ebKqLBjYurz0EfhxziOS0OxveHmJi+4clO DVwN1WfC4h9p137fJOctKWynoA75vItaZgZuab7sWwOA2wv33TN1isAcPXGkNIOX s7xCyMM7nhk1XGZD9epVGqhlKwJaRobDGEjaz4P6OWwIrpyVOQfv+xcDgBM4MiK7 /15uv20/hLfZXIfcgfuB/eUEV+UHSgfgI7AzZgpfyEkA+WRsn15Npds9TbEk9PTw mVIZYMdnsQzPV0ODFCxhuNP64A9BfA== =o7Oq -----END PGP SIGNATURE----- --s5q23k2nvqkztuhz--