Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751548AbdFFTAW (ORCPT ); Tue, 6 Jun 2017 15:00:22 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:36712 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751416AbdFFTAU (ORCPT ); Tue, 6 Jun 2017 15:00:20 -0400 Date: Tue, 06 Jun 2017 15:00:15 -0400 (EDT) Message-Id: <20170606.150015.1247326483451270973.davem@davemloft.net> To: richardcochran@gmail.com Cc: rafalo@cadence.com, nicolas.ferre@atmel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, harini.katakam@xilinx.com, andrei.pistirica@microchip.com Subject: Re: [PATCH v2 3/4] net: macb: macb.c changed to macb_main.c From: David Miller In-Reply-To: <20170606183933.GA1205@localhost.localdomain> References: <1496413439-12900-1-git-send-email-rafalo@cadence.com> <1496413661-21452-1-git-send-email-rafalo@cadence.com> <20170606183933.GA1205@localhost.localdomain> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 06 Jun 2017 11:18:41 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 564 Lines: 18 From: Richard Cochran Date: Tue, 6 Jun 2017 20:39:33 +0200 > On Fri, Jun 02, 2017 at 03:27:41PM +0100, Rafal Ozieblo wrote: >> drivers/net/ethernet/cadence/macb.c | 3568 ------------------------------ >> drivers/net/ethernet/cadence/macb_main.c | 3568 ++++++++++++++++++++++++++++++ > > You deleted macb.c, and so ... Rename macb.c to macb_main.c >> +macb-y := macb_main.o >> >> obj-$(CONFIG_MACB) += macb.o > > how does this rule make sense any more? He's adjusting the Makefile so that it build macb_main.c into macb.o