Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751668AbdFFTNY (ORCPT ); Tue, 6 Jun 2017 15:13:24 -0400 Received: from out02.mta.xmission.com ([166.70.13.232]:51411 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751653AbdFFTLw (ORCPT ); Tue, 6 Jun 2017 15:11:52 -0400 From: "Eric W. Biederman" To: linux-kernel@vger.kernel.org Cc: linux-api@vger.kernel.org, Linus Torvalds , Oleg Nesterov , Ingo Molnar , Thomas Gleixner , Kees Cook , Roland McGrath , Al Viro , David Howells , "Michael Kerrisk (man-pages)" , "Eric W. Biederman" Date: Tue, 6 Jun 2017 14:03:17 -0500 Message-Id: <20170606190338.28347-5-ebiederm@xmission.com> X-Mailer: git-send-email 2.10.1 In-Reply-To: <20170606190338.28347-1-ebiederm@xmission.com> References: <877f0pym71.fsf@xmission.com> <20170606190338.28347-1-ebiederm@xmission.com> X-XM-SPF: eid=1dIJtK-0006wd-75;;;mid=<20170606190338.28347-5-ebiederm@xmission.com>;;;hst=in02.mta.xmission.com;;;ip=97.121.81.159;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1/z5tv6AHJrsizlKarmWderFy+ya6Q4Ic0= X-SA-Exim-Connect-IP: 97.121.81.159 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.7 XMSubLong Long Subject * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.0 TVD_RCVD_IP Message was received from an IP address * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa01 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa01 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: **;linux-kernel@vger.kernel.org X-Spam-Relay-Country: X-Spam-Timing: total 5556 ms - load_scoreonly_sql: 0.05 (0.0%), signal_user_changed: 3.0 (0.1%), b_tie_ro: 2.1 (0.0%), parse: 1.21 (0.0%), extract_message_metadata: 26 (0.5%), get_uri_detail_list: 1.91 (0.0%), tests_pri_-1000: 11 (0.2%), tests_pri_-950: 2.0 (0.0%), tests_pri_-900: 1.64 (0.0%), tests_pri_-400: 29 (0.5%), check_bayes: 27 (0.5%), b_tokenize: 11 (0.2%), b_tok_get_all: 7 (0.1%), b_comp_prob: 4.0 (0.1%), b_tok_touch_all: 2.8 (0.1%), b_finish: 0.73 (0.0%), tests_pri_0: 379 (6.8%), check_dkim_signature: 0.87 (0.0%), check_dkim_adsp: 4.2 (0.1%), tests_pri_500: 5099 (91.8%), poll_dns_idle: 5091 (91.6%), rewrite_mail: 0.00 (0.0%) Subject: [PATCH 05/26] exit: Remove the pointless clearing of SIGPENDING in __exit_signal X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1109 Lines: 32 Handling of signals does not happen once do_exit is called as a process never again exits from the kernel. So remove this ancient hold over from something else. Furthermore this is TIF_SIGPENDING on a zombie. Which will never be scheduled on a cpu again. Setting sigpending=0 was silly in 2.4 when exit_sighand did it and was called from do_exit. When exit_sighand started being called from release_task the code went from silly to completely pointless. History tree: https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git/ Fixes: 6dfc88977e42 ("[PATCH] shared thread signals") Signed-off-by: Eric W. Biederman --- kernel/exit.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/exit.c b/kernel/exit.c index 8926cdd132f2..c3de7ace243c 100644 --- a/kernel/exit.c +++ b/kernel/exit.c @@ -164,7 +164,6 @@ static void __exit_signal(struct task_struct *tsk) spin_unlock(&sighand->siglock); __cleanup_sighand(sighand); - clear_tsk_thread_flag(tsk, TIF_SIGPENDING); if (group_dead) { flush_sigqueue(&sig->shared_pending); tty_kref_put(tty); -- 2.10.1