Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751552AbdFFTcJ (ORCPT ); Tue, 6 Jun 2017 15:32:09 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33880 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751448AbdFFTbF (ORCPT ); Tue, 6 Jun 2017 15:31:05 -0400 Date: Tue, 6 Jun 2017 21:30:58 +0200 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Vineet Gupta , Bart Van Assche , Robin Murphy , Joerg Roedel , Johan Hovold , Alexey Kardashevskiy , Krzysztof Kozlowski , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 10/16] powerpc: vio: use dev_groups and not dev_attrs for bus_type Message-ID: <20170606193058.GA2497@kroah.com> References: <20170606192221.1617-1-gregkh@linuxfoundation.org> <20170606192221.1617-11-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170606192221.1617-11-gregkh@linuxfoundation.org> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2304 Lines: 62 On Tue, Jun 06, 2017 at 09:22:15PM +0200, Greg Kroah-Hartman wrote: > The dev_attrs field has long been "depreciated" and is finally being > removed, so move the driver to use the "correct" dev_groups field > instead for struct bus_type. > > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc: Vineet Gupta > Cc: Bart Van Assche > Cc: Robin Murphy > Cc: Joerg Roedel > Cc: Johan Hovold > Cc: Alexey Kardashevskiy > Cc: Krzysztof Kozlowski > Cc: > Signed-off-by: Greg Kroah-Hartman > --- > arch/powerpc/platforms/pseries/vio.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/pseries/vio.c b/arch/powerpc/platforms/pseries/vio.c > index 28b09fd797ec..fd6595598662 100644 > --- a/arch/powerpc/platforms/pseries/vio.c > +++ b/arch/powerpc/platforms/pseries/vio.c > @@ -1537,6 +1537,7 @@ static ssize_t name_show(struct device *dev, > { > return sprintf(buf, "%s\n", to_vio_dev(dev)->name); > } > +static DEVICE_ATTR_RO(name); > > static ssize_t devspec_show(struct device *dev, > struct device_attribute *attr, char *buf) > @@ -1545,6 +1546,7 @@ static ssize_t devspec_show(struct device *dev, > > return sprintf(buf, "%s\n", of_node_full_name(of_node)); > } > +static DEVICE_ATTR_RO(devspec); > > static ssize_t modalias_show(struct device *dev, struct device_attribute *attr, > char *buf) > @@ -1566,6 +1568,7 @@ static ssize_t modalias_show(struct device *dev, struct device_attribute *attr, > > return sprintf(buf, "vio:T%sS%s\n", vio_dev->type, cp); > } > +static DEVICE_ATTR_RO(modalias); > > static struct device_attribute vio_dev_attrs[] = { > __ATTR_RO(name), > @@ -1573,6 +1576,13 @@ static struct device_attribute vio_dev_attrs[] = { > __ATTR_RO(modalias), > __ATTR_NULL > }; > +static struct attribute *vio_dev_attrs[] = { Hm, this feels wrong, odd that 0-day passed it. I should be deleting the above vio_dev_attrs field as well. Is powerpc really a dead platform? :) thanks, greg k-h