Date: Sat, 7 Jun 2003 13:06:25 -0700
From: Andrew Morton <akpm@digeo.com>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: bcollins@debian.org, linux1394-devel@lists.sourceforge.net,
       linux-kernel@vger.kernel.org, trivial@rustcorp.com.au
Subject: Re: [patch] 2.5.70-mm5: fix ieee1394_core.c compile if
 !CONFIG_PROC_FS
Message-Id: <20030607130625.37f077da.akpm@digeo.com>
In-Reply-To: <20030607144558.GO15311@fs.tum.de>
References: <20030607144558.GO15311@fs.tum.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 964
Lines: 29

Adrian Bunk <bunk@fs.tum.de> wrote:
>
> I got the following compile error with !CONFIG_PROC_FS:
> 
> The following patch fixes it:
> --- linux-2.5.70-mm5/drivers/ieee1394/ieee1394_core.c.old	2003-06-07 16:42:35.000000000 +0200
> +++ linux-2.5.70-mm5/drivers/ieee1394/ieee1394_core.c	2003-06-07 16:42:47.000000000 +0200
> @@ -1228,7 +1228,9 @@
>  
>  	unregister_chrdev(IEEE1394_MAJOR, "ieee1394");
>  	devfs_remove("ieee1394");
> +#ifdef CONFIG_PROC_FS
>  	remove_proc_entry("ieee1394", proc_bus);
> +#endif
>  }
>  

proc_fs.h has:

static inline void remove_proc_entry(const char *name, struct proc_dir_entry *parent) {};

for the !CONFIG_PROC_FS case, so that _should_ have prevented this problem.
 What went wrong?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/