Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751494AbdFFTxl (ORCPT ); Tue, 6 Jun 2017 15:53:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:47476 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751436AbdFFTwe (ORCPT ); Tue, 6 Jun 2017 15:52:34 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 05D21239E2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Tue, 6 Jun 2017 16:52:28 -0300 From: Arnaldo Carvalho de Melo To: Milian Wolff Cc: Namhyung Kim , "linux-kernel@vger.kernel.org" , linux-perf-users , Arnaldo Carvalho de Melo , David Ahern , Peter Zijlstra , Yao Jin , kernel-team@lge.com Subject: Re: [PATCH 6/7] perf report: mark inlined frames in output by " (inlined)" suffix Message-ID: <20170606195228.GB30074@kernel.org> References: <20170518193411.22380-1-milian.wolff@kdab.com> <2569406.pAYQppI5ax@agathebauer> <3456459.puB1FN52Ey@milian-kdab2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3456459.puB1FN52Ey@milian-kdab2> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1221 Lines: 27 Em Tue, Jun 06, 2017 at 09:26:47AM +0200, Milian Wolff escreveu: > On Tuesday, June 6, 2017 3:33:49 AM CEST Namhyung Kim wrote: > > On Sat, Jun 3, 2017 at 10:51 PM, Milian Wolff wrote: > > > The current API seems to pass the data around mostly using the > > > addr_location struct, which is usually constructed on the stack and not > > > always memset to zero. As such, my initial plan of adding a srcline > > > member there would require me to go through all the code to ensure that > > > we memset the struct to zero... > > > Alternatively, I'd have to change the API of hist_iter_ops, to let the > > > callback take another `const char **srcline` out parameter. This is also > > > going to be quite a large invasive change. > > > Do you have any suggestions on how to make this work? > > I think passing srcline via addr_location might not be very invasive > > since it calls machine__resolve() in most cases. Missing places that > > set al->sym should set al->srcline as well IMHO. I haven't looked if it would be invasive or not, good that it isn't, but then I think addr_location is the right place for this to be stored. > OK, perfect - I'll implement that then. Thanks, - Arnaldo