Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751531AbdFFUEv (ORCPT ); Tue, 6 Jun 2017 16:04:51 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:38080 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751239AbdFFUEu (ORCPT ); Tue, 6 Jun 2017 16:04:50 -0400 Date: Tue, 06 Jun 2017 16:04:48 -0400 (EDT) Message-Id: <20170606.160448.1263511411241760892.davem@davemloft.net> To: vivien.didelot@savoirfairelinux.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, f.fainelli@gmail.com, andrew@lunn.ch Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: fix 6085 frame mode masking From: David Miller In-Reply-To: <20170605221716.32235-1-vivien.didelot@savoirfairelinux.com> References: <20170605221716.32235-1-vivien.didelot@savoirfairelinux.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 06 Jun 2017 12:23:11 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 443 Lines: 11 From: Vivien Didelot Date: Mon, 5 Jun 2017 18:17:16 -0400 > The register bits used for the frame mode were masked with DSA (0x1) > instead of the mask value (0x3) in the 6085 implementation of > port_set_frame_mode. Fix this. > > Fixes: 56995cbc3540 ("net: dsa: mv88e6xxx: Refactor CPU and DSA port setup") > Signed-off-by: Vivien Didelot Applied, thanks Vivien.