Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751482AbdFFWFm (ORCPT ); Tue, 6 Jun 2017 18:05:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:58164 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751401AbdFFWFk (ORCPT ); Tue, 6 Jun 2017 18:05:40 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD68223A02 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh+dt@kernel.org MIME-Version: 1.0 In-Reply-To: <1496776664.3821.3.camel@seibold.net> References: <1496667567-13266-1-git-send-email-stefani.seibold.ext@huawei.com> <1496688186.12947.10.camel@hp800z> <1496776664.3821.3.camel@seibold.net> From: Rob Herring Date: Tue, 6 Jun 2017 17:05:18 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] external references for device tree overlays To: Stefani Seibold Cc: Pantelis Antoniou , Stefani Seibold , Frank Rowand , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Holm Rauchfuss Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1575 Lines: 58 On Tue, Jun 6, 2017 at 2:17 PM, Stefani Seibold wrote: > Hi Pantelis, > > thanks for the suggestion. This feature is not very well documented. I > tried this on my rasp1 running 4.12.0-rc3 and it doesn't work. My > source is: > > // rapsi example > /dts-v1/; > /plugin/; > > / { > compatible = "brcm,bcm2835", "brcm,bcm2708", "brcm,bcm2709"; > > fragment@0 { > target-path = "/soc/i2s@7e203000"; > __overlay__ { > #address-cells = <0x00000001>; > #size-cells = <0x00000001>; > test = "test"; > timer = <&{/soc/timer@7e0030000}>; > }; > }; > }; > > > The resulting overlay is (decompiled with fdtdump): > > /dts-v1/; > // magic: 0xd00dfeed > // totalsize: 0x19a (410) > // off_dt_struct: 0x38 > // off_dt_strings: 0x148 > // off_mem_rsvmap: 0x28 > // version: 17 > // last_comp_version: 16 > // boot_cpuid_phys: 0x0 > // size_dt_strings: 0x52 > // size_dt_struct: 0x110 > > / { > compatible = "brcm,bcm2835", "brcm,bcm2708", "brcm,bcm2709"; > fragment@0 { > target-path = "/soc/i2s@7e203000"; > __overlay__ { > #address-cells = <0x00000001>; > #size-cells = <0x00000001>; > test = "test"; > timer = <0xdeadbeef>; > }; > }; > __fixups__ { > /soc/timer@7e0030000 = "/fragment@0/__overlay__:timer:0"; Looks like you (Pantelis had the typo) have an extra 0 in 7e0030000 compared to your original example. Rob