Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751829AbdFFXDc (ORCPT ); Tue, 6 Jun 2017 19:03:32 -0400 Received: from mail-cys01nam02on0072.outbound.protection.outlook.com ([104.47.37.72]:7520 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751632AbdFFXBk (ORCPT ); Tue, 6 Jun 2017 19:01:40 -0400 Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH 2/2] amd: uncore: Get correct number of cores sharing last level cache To: Borislav Petkov , Peter Zijlstra Cc: Janakarajan Natarajan , linux-kernel@vger.kernel.org, Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Suravee Suthikulpanit References: <42ddf980f25ffd0ba585f3cf3a7ca9ade4fc7bee.1496418338.git.Janakarajan.Natarajan@amd.com> <20170606101530.ehgizupxz4hy7ccv@hirez.programming.kicks-ass.net> <20170606174502.i4wc2xjge6lp4soy@pd.tnic> From: Janakarajan Natarajan Message-ID: <824ebd7d-40a1-6e74-f0b7-2b6dd408edb4@amd.com> Date: Tue, 6 Jun 2017 18:01:33 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170606174502.i4wc2xjge6lp4soy@pd.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BN6PR04CA0026.namprd04.prod.outlook.com (10.174.93.143) To DM5PR12MB1675.namprd12.prod.outlook.com (10.172.40.144) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR12MB1675: X-MS-Office365-Filtering-Correlation-Id: 31413f7c-84db-4a5d-01de-08d4ad2ffc7f X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(201703131423075)(201703031133081);SRVR:DM5PR12MB1675; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1675;3:DCNQMwBaAMkDKwSpUQsavrkL21OltyUhIU7lbS3FAzUN4ZJFEgK1So45sUv1fhKz38juYhUDL7Sb/NIEo/YoObM+u/rI1F19k6W5mXGVO/+9XMDahucB/FATcXwpzjGMQ1H4o9/9ayMWOwBPRSERuMZ5Ty+hgfx5lpq+MDuo7elQ6rKEKESJKborzksFpxSov1ggU0OLamiGYK3hKl4RIjq0TwcI9+2epGXN2+nQXQGZ+c0qEPbRdsFdq9GviSEMMzPcjlIO56ex0rXzjhUJj4y1SehnNRHLxOofzIGWdCgXYJGEGZ5/L5o91FMX6vdIV0dJfQ9yf3aT8KIYFXXNQF504au5BeiErM3tVPyC1sM=;25:gEbpi/FMtbXVQk3ntnvAZhsRjap3UImlzvW7ZLvIjU7nBCpsPYnfJes11RpfKUEr/k2Z2S6qYkV8RJXG1jBm+rZ/ogt4AkzQi+SzcE4qjq3VByCZygfOgUGwtAbQM4GV8Bhn92FPAQkF3OU6MhHK28oe3axXnzYe+Cg8R14ba4w1DoT4L/FfNJUsvC5pTaKb+ewY/jfY9JvZC/Q/31sJ2wYRvHKJefM1kJfZtKahjw1CVWROS2XPxsQ+P512bVZi7k/XAG97tDcaDDwCdRP/ULGmzgDJUtx53jtI610yJXzFTzWPTl1DBEgNQeQiACe3DEPKjWsfXufTtVcO+k5/v+gVHoMwP3a9NrZM58zcxRV8hvXCYGM9X4l6gEqf0648hIcp97OEtp1/lEQHw+gszSojNMdlBSzUwmVaZL/vFp/0RlSgCB7whpQwEdRjB+NcE2dCjRmWvdlN+ISD6qntwU0ZfG2C286vpUGT07MlszA= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1675;31:3kLSoOrBuaaEsxatzPz6bU7wmwRCSTFs0Qsu1Gek6sNQYls/ofrsXEEhkolW0CZAEt7n+gUQvr0+8kcti6sgo3wON3k8D0m1x849nP+nisjpXrx0JIUl3RzQLyxFq7ii1OSzpfpUi98B2fQtaNryJZJe71e2wQf/INr88q69W/wWGz6QsbkZQrxdKzSASHIXG6zBso+vMYe2T8S3NoS5NJn3n2ZO0htTPUAp6Ow2SfI=;20:ITilMLCtCYyJ+OfriprWfsVnBGDZzl6kHIpXpsbxGvCBiuDBOb3wvhBFMIav3nf8fJNBMaT1qMH3Do+OdYNKBlhSMvQ2tSgHmv9Zil9tyDDxRJQ16lZSnz9c2Pjkb6qmT/J/VP5OC86dKUJO/iW3mi8enyRi7slMZaOjV3ITnK190Oq3igB9Jd04pftpEwhVJcuhEcEMMUqStSZCf5kbNaa0n6PlVK0xMr6EdfNbzD8eG7+46jKLpsG5tahIuGaUJY4fKZG853N79ayHVcWGo9+5eE/7blC9epfDnthJB3K4Jh9v5IBEvoq/3qMSDRL0rc8xnufwdXW5XPu3XS3M51iRU3UwPDCip9u3AlIn8al+ZHSfLpIyCBKvw9oapQ+SV3dBF0EzSqljDFSrBQO+vD6Qu5An0+xXAdpxqB85KxhND9RfgaC5npFSHnAjE8KTq6uModwkF047jZ7XPRPJt2BBDuoDFES1/GH/6mZChtVVLp3I3pz8T2Yb5PezrnFJ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123560025)(20161123562025)(20161123555025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM5PR12MB1675;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM5PR12MB1675; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjEyTUIxNjc1OzQ6RFBLV0N5andxZ1BTeXZZVXEzcUZwVjZSRmZS?= =?utf-8?B?NUIxQ1dUM3FWT015Y2krSnFHUU5SRUZYOHhjTmdWa3hZVGRTYm9FM3NidGZs?= =?utf-8?B?RFRtY2gxVEdkVlpSa3ZCSy8rRGVFZ2VybmI0NTFQM2I0N2Ewb2FlcEtvTEJO?= =?utf-8?B?NUdHR3E3ZklqZVhROE1tbTRsQjIyWlp6Z0w4UVVlODdKdG5weFZQemZmS2ph?= =?utf-8?B?YmJiZnRwblU5Qjl6T24xVmJJYlZVS3lsYk95clVkNE0zNjM0TmxZWUZUR2Uv?= =?utf-8?B?ck1zOXQ5RTI5enA4SkY4aXBGYllNSWFkbHdaL3RyVTNDV2htZFVNZ2xFWFYy?= =?utf-8?B?N2tobXBUMUhZbkI3T04xOXQrYTlMVHc2Um9xMkpWdW9OV3M0TG1uZ1NBOEFR?= =?utf-8?B?bEw4WExyVjFTOXA1Y3dEdm5ZN0dhUFJucXFIYk9mWUlrMnFET1JxVEI1ZUp1?= =?utf-8?B?T2s2R05saXlnTDRFQW9BTUhYT1FmQ1Iyd0NBTTV0eVhKenJHRWdodCswMGo1?= =?utf-8?B?RlZTQUhGdlZ1YWpRbG9KdDQvMmszWXlVSzJzQ1JhamxGWEs0SzYxeHhCRXI4?= =?utf-8?B?STNIN2U3SWd5S1crdUlUQzFPTTRSOVNOaUlKdkVOd2pkRG9Ud2VDcDFRMi9a?= =?utf-8?B?Q0NIV1cxQ1p1VmRCRVRxNEE5aGFGQ1ZHTElzL1RmcnNub0hGN2psMjhoaVNr?= =?utf-8?B?a1hPeUFyQnI0aWxDVjFxZXIxN2xLdGwwOS9uQnBwSmEvR0p2WU1Bd3lya0NE?= =?utf-8?B?RG9MQng4OE9DMnVlMGNnTC9wWTQ0NkJ4Y0h5REoyZlY1MThpVHZrNHhMRlBB?= =?utf-8?B?alFkZGJjRVJTRjMrL0NyamxKRG5CemQ4eXhjNGU5UEo4aVNTcVJ3ZnhENnVX?= =?utf-8?B?ang0a1FoaENFTWhGN21veStzSDh5dHRFak5DY0RoWGI1RTRLUGpiSkxLSlor?= =?utf-8?B?Nm5BZGZ2WGRlQkwwbFBDVmJsY3N3QUdGYXp6a1FQYk9hMVVEV1ZPVVNYVHVX?= =?utf-8?B?THRwZHEwaGNZQkdwR2pKZ1RLcytGL0FBSkpWakh3SThTVjFuc0wyOWJvaHJY?= =?utf-8?B?RnNCRUJzb3VLeXZ5WVo2bzNvdE8xMTRQUWlIT3AzYTVoMnF2WTFNSTVpMTA0?= =?utf-8?B?YXEzQ1A4aGpVVjVmbHQySnJ4a0RocUJrMDlkNWdQcFd4dVJkalVjRnFLOVZx?= =?utf-8?B?aUNnNzFoOGUrUG1aTitYbjRiMnExL01lVWZvR24xaWRxSENKRnhWKzcveC9o?= =?utf-8?B?QTNQYll0cGU5M0xHUTBQRUlraTd3eXFBVTlCS093Y0tjc3F1YkxQZmhCUHJB?= =?utf-8?B?cHdMeGVScHlDa1hYZ0ROTjZScnBvdVM2L01DT1I2cmtuNHhpTjk2aFJuYXpC?= =?utf-8?B?cmdCbmdCdVZESFExeDBMSnkvN1QrbG5kWmFCbjVTOGRjbHRxSUxSTHpjYXAx?= =?utf-8?B?dXR5TG9rajJvWnFTdjlkQ1BNSUNWRUZLRmx3T3BHWHpHSU1XZVBkcW9vVDFm?= =?utf-8?B?UnNOTlBqSHpGcmVNWFg3Qk9MdE1kOW0ybnRld0NPM2V4MVN3R1l5QzhQaFF4?= =?utf-8?B?WTI5Nis5SGJVYkdNRTFGcXRYTzcvUT09?= X-Forefront-PRVS: 033054F29A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(39840400002)(39860400002)(39850400002)(39400400002)(39450400003)(39410400002)(377454003)(24454002)(6246003)(38730400002)(47776003)(25786009)(4326008)(54906002)(53936002)(6486002)(77096006)(53546009)(90366009)(31696002)(2950100002)(305945005)(65956001)(5660300001)(93886004)(65826007)(229853002)(7736002)(66066001)(6666003)(65806001)(76176999)(42186005)(54356999)(4001350100001)(50986999)(36756003)(31686004)(478600001)(72206003)(64126003)(2906002)(50466002)(33646002)(8676002)(81166006)(83506001)(230700001)(23676002)(3846002)(6116002)(189998001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB1675;H:[10.236.136.61];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjEyTUIxNjc1OzIzOnpKQ1d1d1IwODcrc1NTNVBKMTJmZ0NuZUdM?= =?utf-8?B?TStUYnRYMHQyUjc2OGhtN1d6Y2E3blB2V0tjNlhLS2ZtVUxKRXNwL3RSLzh5?= =?utf-8?B?WmJXZGFDcGlxam53RkhVeUVBZnZnei9uMGV6VHgwc29BYlJaTURSOWh3NWdZ?= =?utf-8?B?NjRRZjdhNVJFbjdqcVU3VVFiR1IwVEMxOXpJb1NXaTRmRitBbkEyY2RvY3I3?= =?utf-8?B?M2JkQUVtTk5aZmczWDBna3ZiaFM1OWlSWGhCU0xHVUhraFMrVW5nVG5xc3R2?= =?utf-8?B?NUp1SDNiZzM4ZzBLZHhHaUJhWjNyRWl2YWs4NWpCZHVraWdBTmUzWWNMYkdS?= =?utf-8?B?UmxpcE1rZVM2UThQR0JjbkZ6aEd1TGV1VUVldmM2K1VpVkExVnUxZ0VmY2FH?= =?utf-8?B?WEVyaFpwZEFKWnk3UTJUdm5GUERYZTJQbW91MUs3cUhrNU9QSXorYTFHbVAr?= =?utf-8?B?dVc5KzJmYTZqelk2eitvZ2pCYVltd2Vkclc1VFF2Q0s0c3FLdXRQa0dQUjhz?= =?utf-8?B?b1JJWnNoWVYzWWdGcG9NS3lhbXRHOEdKSVJ6aDllVHZjUHVuQy9OczRNdVBj?= =?utf-8?B?bjc5WkFuZGxPRElGWUF2aWQrNDZTdTZyVVZ0Mng1SjgvdGdkaWZaVWY3MVFr?= =?utf-8?B?Qm9Jc0x0NnBDYnBjSDhYbkN6ZEJiMVh6dXZpYzBldnpSZXRjalo2OFU0Y0JH?= =?utf-8?B?M0hnWVJZYVQ5cnRxcUJJLy9CcXZVME5CaHduTWRKRXJWdGdnZ0JhVm5BaE1p?= =?utf-8?B?eklsK3ZqdHp5bGphWjRHQWVPc0M2UXRYa0N6UW5pMzdOL2hFTFVxTGN5eS9u?= =?utf-8?B?bWpUUTR0MWNHUUxWYjdGeXVYSmsvaFZSeG5oZXpTLzlIZEdEUm8xYThHOGxB?= =?utf-8?B?TWxYQ0RDOHg1eUwrU2VVc1hxZmZzelc1TEREb2hzMlErWGJJUTVhTjdwODU2?= =?utf-8?B?U1orNDdSUkNrUmlXdUtrc2NwS2JkMXNzR2Z6REtGcHQzcDgyc0pZL3Q3bUc3?= =?utf-8?B?OEZwU3dnbSt1a2c3M3ZBcGNUMG9QYnN2UnJ5dDMzVTFZK3FYRWc4dGV2Z3VD?= =?utf-8?B?Uzd6UDl3UDNhRXNlZS9RUjBPQmwyRE5uZkVwUTVCYjROM1M1cmVyNHEvVzB2?= =?utf-8?B?anZ0RWxaRkFOQS9TMHdKQWV4Z3huN0JsaGFwZmRKOW5lQllyTTRYUkZRd0JZ?= =?utf-8?B?SkRSVC8yL0JIYmZVdmNJRENGRUdoYUZMVjE1WXlxdFJkNFBaN3dVN0I0alNP?= =?utf-8?B?anNNcG1JOEFNdit1TS9wN2VoMXZ1Q1VHWURWTlNwZE5QUEFvdEl3aXJ5YXZp?= =?utf-8?B?ZzhLT09NZ1l4QTA3UldTM0F5R0xlczJhanM0UGdVRElQaWJsaVI5U0xIQW9m?= =?utf-8?B?WkJtdTczTmc2dkl4K29oZDNPZmdBZERNem1EOE1lcytFcGhteWhGc1MvNkFp?= =?utf-8?B?Wm9Kcisxajk0YU4ydDB5Nmx6VkZ3VmRhSDhjbGp2ZjYwNGpSNVFjdHFkVzND?= =?utf-8?B?TGNCVWhuVXhpZndOQkZBRy83Ty8yVk00Y2pGb3ZkZkthOS9WNXFveHFXekJO?= =?utf-8?B?UVRidDRrZFltU2FoYi9qUDMwMXhNTXBabDFGc2JIdUw4TWp5aWxXWUIxYnB0?= =?utf-8?B?cHp6cTNGWUxoQ0c4dXlVTHZJUFlPci9kNmUwUzJ3MFNuR2lwN0hzL1dTRUdr?= =?utf-8?B?d1dOUW5mS3piWEpDRVFHa0ZPc1VzakZEbkZTM2ZIak45RVpDUjBOSGZWT000?= =?utf-8?B?RFZHVXZQZnB4WGh6YnlrakQ5SENHYUtOQmg2VDlFYUhNenBWbzdOTXY4TGZp?= =?utf-8?B?OW5LK1VTR3lnVEU4ZWVwdVJTTkY0b2RheVRySk9uNU5hZmc9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1675;6:yMwjfbDqPWEQ6YmO6OWskPIJ3Ms9e1zHbY8OfNN5uNov11HW4AotDpdBV3n19L70Jv4Q7uojnNPTOqU0btZAPyNZU3Me2m4ahpKpbdhyUMe69pbFY0lMgleerjEc+oCjm/YPVJh5PP9nNzEbHcw58oJG/r2T1IGvxSld21nPHBjI6KX6/rwBi2ecly91CmjEXDUU4UlByaKbwvVEVpKhYx1HxfZoXHMgImJOP9k9wDlBaFpCbWk/lcxWJskRnF3dDPFjcLxO7Fqdk7B/7729ZoMW6jB9K2a09noJbdyh01KgbK6YJ7Y70cQoilOI2G8jsXCwEFW4lQjOss0LNM/K2rYfhJqfeVuSgMHzv5fpVgOspv4pXG40bn31sWDOSOqZHKlo+wd4pkAhrCQPgWnzMxfADhlwGoLcmsMoVVBU1HQePYmYCgIAGiwoqx2zKplPB9qs2xlQxl+1gnuAAVzZULMGW2duX7QT/+QAocUIZINKTlfVC+4C7C64QqtWbCi4KW1FuOl/7yuX/nKvC6/3RNl4uAnU9XXG7IzKM+qk8rQ= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1675;5:yLI8d7nlnsTh4o5bC232TmWz+P/hBp6Kt7fzDd2pnm86VWo1GdbwtjBYCiiw3UKjIhUQyDA6CEJ6ISXRmH9Qwymh4/3IZWPA3RssqJIZr4gc0pH7p/yLLgmFOOjMFEVHPE/KbgQ7xAR+H+CDCBeYS+3QmkdEV/2WxEIuqeH/edgdXet5YQYab+Prz4zx3qEnYae5lsPFZw/JQGRZuMXzApUpdslujJdTZ+qnrCApAk6jOUi6DX93mR25LqJrYzh81wFVeRXokPjDH1BCWD6DRmWHY5bao+taFTS4Vxd/BbprHqYTKtr+s5ImW7X1OOHQqOrIF9eMUT8L51h/swIiYLGGFwOqRgZFF18QG3q09Wq0c/6vxYBxfoWRmkaq1Qe0Nph95heAA6Y5Oya5WH0SyI08KPDDTxPyMj4vpkkSyQcoZBlzfO+wvq5lau6ol7c2osNO7P8nFEYjdWrnOaAue6NuSHP6zHNzshuUIBAKFafO+miCYaznZHxhxtdXLboq;24:mKRJgCLtyo/Q7pHwOwHJ09CORffLhQinvluGUTkMY/PS+/OEqQqPpJZtThqebWl3ES/kcTxc72pieIbhJJPRi+wFz4bLetaldUWUyxoh5EY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1675;7:sh+60HzBDLX+4QqYe4NBhQaUHxG/G12iafA0tBEDGb4VcZVSkgeOghIAWboGLTbdcAWBGK1uWgSN9aGvHTdkVwdLVHavpVhlCD27d3I7XNKW+4DRvEvKVKM4yAVW5aIwRLN8J54TYJUI+UwLKK0H/jH57mszJGX3hYvphwPxdR/5TPt/GeyFv4IVRf9+P3qpnetGmAe3ewBqSLDug6CjBo0/7obWwJhZatRmCsg3gTWeGI5uSpT3tDYXeqKckeN1LezvRjXoXIO7PmHc4J2cBQiLK/2V7st1aRxXz4X/ve+hpnb0kmDm621SM8BbbBv6GCSJ1USFm8twGOMe8wUpaw==;20:tolr6rmcX3znRPobxg2mX1i1ELntZDsc98+686vYQD8L+gKNrsa62ZqrVMSUoQzzU2PWn70YGrmLYG5cBmoaqslt5e4bSsGs5cw2pnF6d0ZB+pK9Csc3Jaja91ZKVXkj/ck8VHuxKYHAwNF2/GInUKUM5mZ4n72FS5ewTSQtcSTITGA3QltGuEoeJ6dkAmY6D98UiTWhaB6+TE4VGcP9FJ8mOnEVWNBmK3azNqfFhIHscIrQFuonKK6OYeZg3uap X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2017 23:01:36.8113 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1675 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 630 Lines: 22 On 06/06/2017 12:45 PM, Borislav Petkov wrote: > On Tue, Jun 06, 2017 at 12:15:30PM +0200, Peter Zijlstra wrote: >> Maybe something like: >> >> for (cache_level = 0; cache_level < 3; cache_level++) { >> cpuid_count(0x8000001d, cache_level, &eax, &ebx, &ecx, &edx); >> >> if ((eax & 0x1f) == 0) /* EAX[0:4] gives cache type */ > if (!(eax & 0x1f)) > >> break; >> >> prev_eax = eax; >> } >> >> That way we'll not run off into the woods if CPUID goes funny (never >> trust a BIOS/virt monkey). > Yap, especially if there are CPUID functions with subleafs with holes in > them. Okay. I can send a v2 with the changes. >