Date: Wed, 7 Jun 2017 08:42:24 +0900
From: Byungchul Park <byungchul.park@lge.com>
To: Juri Lelli <juri.lelli@arm.com>
CC: <peterz@infradead.org>, <mingo@kernel.org>,
        <linux-kernel@vger.kernel.org>, <juri.lelli@gmail.com>,
        <rostedt@goodmis.org>, <kernel-team@lge.com>
Subject: Re: [PATCH 2/2] sched/deadline: Don't return invalid cpu in
 cpudl_maximum_cpu()
Message-ID: <20170606234224.GD3623@X58A-UD3R>
References: <1496388663-29067-1-git-send-email-byungchul.park@lge.com>
 <1496388663-29067-2-git-send-email-byungchul.park@lge.com>
 <20170606151225.xlhrnh2usajmlu52@e106622-lin>
MIME-Version: 1.0
In-Reply-To: <20170606151225.xlhrnh2usajmlu52@e106622-lin>
User-Agent: Mutt/1.5.21 (2010-09-15)
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1047
Lines: 39

On Tue, Jun 06, 2017 at 04:12:25PM +0100, Juri Lelli wrote:
> Hi,
> 
> On 02/06/17 16:31, Byungchul Park wrote:
> > When the heap tree is empty, cp->elements[0].cpu has meaningless value.

Hi,

The meaningless value is 0.

> > We need to consider the case.
> > 
> > Signed-off-by: Byungchul Park <byungchul.park@lge.com>
> > ---
> >  kernel/sched/cpudeadline.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/kernel/sched/cpudeadline.c b/kernel/sched/cpudeadline.c
> > index d4a6963..9b314a9 100644
> > --- a/kernel/sched/cpudeadline.c
> > +++ b/kernel/sched/cpudeadline.c
> > @@ -110,7 +110,8 @@ static void cpudl_heapify(struct cpudl *cp, int idx)
> >  
> >  static inline int cpudl_maximum_cpu(struct cpudl *cp)
> >  {
> > -	return cp->elements[0].cpu;
> > +	int cpu = cp->elements[0].cpu;
> > +	return cp->elements[cpu].idx == IDX_INVALID ? -1 : cpu;
> 
> Mmm, don't we get a WARN from cpumask_check() if we return -1 here?

The function does not return -1 without my patch.

Right?

> 
> Thanks,
> 
> - Juri