From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "jslaby@suse.com" <jslaby@suse.com>,
        "andreyknvl@google.com" <andreyknvl@google.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC: "syzkaller@googlegroups.com" <syzkaller@googlegroups.com>,
        "kcc@google.com" <kcc@google.com>,
        "dvyukov@google.com" <dvyukov@google.com>
Subject: Re: tty: possible deadlock in tty_buffer_flush
Thread-Topic: tty: possible deadlock in tty_buffer_flush
Thread-Index: AQHS3yZhUiLiXMyGw0Gdw6gjVCiSOaIYj34A
Date: Wed, 7 Jun 2017 00:42:12 +0000
Message-ID: <1496796130.2692.26.camel@sandisk.com>
References: <CAAeHK+zOQRExvWzZQKpHhsdOnVah=zDsBdL2Q_SpamL1ttv4gg@mail.gmail.com>
In-Reply-To: <CAAeHK+zOQRExvWzZQKpHhsdOnVah=zDsBdL2Q_SpamL1ttv4gg@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <00A1302303B0AB4BAD8ACB7DB51B8EA7@namprd04.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2017 00:42:12.5705
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1536
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v570gK3c019141
Content-Length: 913
Lines: 27

On Mon, 2017-05-29 at 17:19 +0200, Andrey Konovalov wrote:
> I've got the following error report while fuzzing the kernel with syzkaller.
> 
> On commit 5ed02dbb497422bf225783f46e6eadd237d23d6b (4.12-rc3).
> 
> ======================================================
> WARNING: possible circular locking dependency detected
> 4.12.0-rc3+ #369 Not tainted
> ------------------------------------------------------
> kworker/u9:1/31 is trying to acquire lock:
>  (&buf->lock){+.+...}, at: [<ffffffff823dd42b>]
> tty_buffer_flush+0xbb/0x3b0 drivers/tty/tty_buffer.c:221
> 
> but task is already holding lock:
>  (&o_tty->termios_rwsem/1){++++..}, at: [<ffffffff823cd5d1>]
> isig+0xa1/0x4d0 drivers/tty/n_tty.c:1100
> 
> which lock already depends on the new lock.

Hello Andrey,

I also see this warning but during regular boot (without running syzkaller).
Do you perhaps have the time to bisect this?

Thanks,

Bart.