Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751511AbdFGBHi (ORCPT ); Tue, 6 Jun 2017 21:07:38 -0400 Received: from mga04.intel.com ([192.55.52.120]:62748 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751436AbdFGBHg (ORCPT ); Tue, 6 Jun 2017 21:07:36 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,308,1493708400"; d="scan'208";a="110036015" From: "Brown, Aaron F" To: "Kirsher, Jeffrey T" , David Miller , "Nikula, Jani" CC: "Ursulin, Tvrtko" , "daniel.vetter@ffwll.ch" , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "jani.nikula@linux.intel.com" , "chris@chris-wilson.co.uk" , "Ertman, David M" , "intel-wired-lan@lists.osuosl.org" , "dri-devel@lists.freedesktop.org" , "netdev@vger.kernel.org" , "airlied@gmail.com" Subject: RE: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails Thread-Topic: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails Thread-Index: AQHS2iVJoQX1p8g1xE+pGQQb87gLQaISWTEAgAZzywD//9NcgA== Date: Wed, 7 Jun 2017 01:07:33 +0000 Message-ID: <309B89C4C689E141A5FF6A0C5FB2118B8C61D137@ORSMSX101.amr.corp.intel.com> References: <20170531.110833.1362264472730468352.davem@davemloft.net> <20170531155043.3596-1-jani.nikula@intel.com> <20170531155043.3596-2-jani.nikula@intel.com> <20170602.141426.713378366601051907.davem@davemloft.net> <1496781986.86439.3.camel@intel.com> In-Reply-To: <1496781986.86439.3.camel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v5717kex025003 Content-Length: 1911 Lines: 48 > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On Behalf > Of Jeff Kirsher > Sent: Tuesday, June 6, 2017 1:46 PM > To: David Miller ; Nikula, Jani > > Cc: Ursulin, Tvrtko ; daniel.vetter@ffwll.ch; intel- > gfx@lists.freedesktop.org; linux-kernel@vger.kernel.org; > jani.nikula@linux.intel.com; chris@chris-wilson.co.uk; Ertman, David M > ; intel-wired-lan@lists.osuosl.org; dri- > devel@lists.freedesktop.org; netdev@vger.kernel.org; airlied@gmail.com > Subject: Re: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo > e1000e_pm_freeze if __e1000_shutdown fails > > On Fri, 2017-06-02 at 14:14 -0400, David Miller wrote: > > From: Jani Nikula > > Date: Wed, 31 May 2017 18:50:43 +0300 > > > > > From: Chris Wilson > > > > > > An error during suspend (e100e_pm_suspend), > > > > ... > > > lead to complete failure: > > > > ... > > > The unwind failures stems from commit 2800209994f8 ("e1000e: > > > Refactor PM > > > flows"), but it may be a later patch that introduced the non- > > > recoverable > > > behaviour. > > > > > > Fixes: 2800209994f8 ("e1000e: Refactor PM flows") > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99847 > > > Cc: Tvrtko Ursulin > > > Cc: Jeff Kirsher > > > Cc: Dave Ertman > > > Cc: Bruce Allan > > > Cc: intel-wired-lan@lists.osuosl.org > > > Cc: netdev@vger.kernel.org > > > Signed-off-by: Chris Wilson > > > [Jani: bikeshed repainted] > > > Signed-off-by: Jani Nikula > > > > Jeff, please make sure this gets submitted to me soon. > > Expect it later tonight, just finishing up testing. Tested-by: Aaron Brown