Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751552AbdFGGRZ (ORCPT ); Wed, 7 Jun 2017 02:17:25 -0400 Received: from mail-oi0-f41.google.com ([209.85.218.41]:33662 "EHLO mail-oi0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751442AbdFGGRY (ORCPT ); Wed, 7 Jun 2017 02:17:24 -0400 MIME-Version: 1.0 In-Reply-To: <20170607061216.GA5929@bbox> References: <1496804917-7628-1-git-send-email-zhongjiang@huawei.com> <20170607035540.GA5687@bbox> <59378799.1050000@huawei.com> <20170607061216.GA5929@bbox> From: vinayak menon Date: Wed, 7 Jun 2017 11:47:23 +0530 Message-ID: Subject: Re: [PATCH] Revert "mm: vmpressure: fix sending wrong events on underflow" To: Minchan Kim Cc: zhong jiang , Andrew Morton , mhocko@suse.com, "linux-mm@kvack.org" , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 983 Lines: 21 On Wed, Jun 7, 2017 at 11:42 AM, Minchan Kim wrote: > On Wed, Jun 07, 2017 at 12:56:57PM +0800, zhong jiang wrote: >> On 2017/6/7 11:55, Minchan Kim wrote: >> > On Wed, Jun 07, 2017 at 11:08:37AM +0800, zhongjiang wrote: >> >> This reverts commit e1587a4945408faa58d0485002c110eb2454740c. >> >> >> >> THP lru page is reclaimed , THP is split to normal page and loop again. >> >> reclaimed pages should not be bigger than nr_scan. because of each >> >> loop will increase nr_scan counter. >> > Unfortunately, there is still underflow issue caused by slab pages as >> > Vinayak reported in description of e1587a4945408 so we cannot revert. >> > Please correct comment instead of removing the logic. >> > >> > Thanks. >> we calculate the vmpressue based on the Lru page, exclude the slab pages by previous >> discussion. is it not this? >> > > IIRC, It is not merged into mainline although mmotm has it. That's right Minchan. That patch was not mainlined.