Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751676AbdFGHMh (ORCPT ); Wed, 7 Jun 2017 03:12:37 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:33489 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751273AbdFGHMd (ORCPT ); Wed, 7 Jun 2017 03:12:33 -0400 MIME-Version: 1.0 In-Reply-To: <20170606135829.dxi3mf7so4j5ml3q@dell> References: <20170606085143.13154-1-guodong.xu@linaro.org> <20170606135829.dxi3mf7so4j5ml3q@dell> From: Arnd Bergmann Date: Wed, 7 Jun 2017 09:12:32 +0200 X-Google-Sender-Auth: WXcEtlEcEEvcTC0N_S79BWOMaQM Message-ID: Subject: Re: [PATCH v4 0/8] MFD: add driver for HiSilicon Hi6421v530 PMIC To: Lee Jones Cc: Guodong Xu , Rob Herring , Mark Rutland , Wei Xu , Catalin Marinas , Will Deacon , Liam Girdwood , Mark Brown , Kevin Hilman , Gregory CLEMENT , Simon Horman , Olof Johansson , Thomas Petazzoni , Masahiro Yamada , Riku Voipio , treding@nvidia.com, Krzysztof Kozlowski , Eric Anholt , damm+renesas@opensource.se, Ard Biesheuvel , Linus Walleij , Geert Uytterhoeven , devicetree@vger.kernel.org, Linux Kernel Mailing List , Linux ARM , hw.wangxiaoyin@hisilicon.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1267 Lines: 29 On Tue, Jun 6, 2017 at 3:58 PM, Lee Jones wrote: > On Tue, 06 Jun 2017, Arnd Bergmann wrote: > >> On Tue, Jun 6, 2017 at 10:51 AM, Guodong Xu wrote: >> > This patchset adds driver for HiSilicon Hi6421v530 PMIC. >> > >> > Mainline kernel already has driver support to a similar chip, Hi6421. >> > Hi6421 and Hi6421v530 are both from the same vendor, HiSilicon, but >> > they are at different revisions. They both use the same Memory-mapped >> > I/O method to communicate with Main SoC. However, they differ quite a >> > lot in their regulator designs. Eg. they have completely different LDO >> > voltage points. >> > >> > Patch 1 and 2 are hi6421-pmic cleaning up. >> > Patch 3 and 4 extends hi6421-pmic-core.c to support Hi6421v530 revision. >> > Patch 5 add hi6421v530-regulator.c driver for LDO regulators. >> > Patch 6 fixes an issue for hi6421 regulator, which is not related to v530 >> > but it's found in this review. >> > Patch 7 is dts change, it depends on and can be applied to hi3660/hikey960 >> > patchset [1]. >> > Patch 8 enables the relevant config items. >> >> Looks good to me, > > Is that an Ack? Yes, sorry for not being explicit about this. Acked-by: Arnd Bergmann