Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751502AbdFGHiO (ORCPT ); Wed, 7 Jun 2017 03:38:14 -0400 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:43408 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750730AbdFGHiN (ORCPT ); Wed, 7 Jun 2017 03:38:13 -0400 MIME-Version: 1.0 In-Reply-To: <20170607072718.18017-2-dannym@scratchpost.org> References: <20170607072718.18017-1-dannym@scratchpost.org> <20170607072718.18017-2-dannym@scratchpost.org> From: Chen-Yu Tsai Date: Wed, 7 Jun 2017 15:37:48 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v10] sun4i-codec: Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In. To: Danny Milosavljevic Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Maxime Ripard , Chen-Yu Tsai , Rob Herring , Kuninori Morimoto , Linux-ALSA , linux-arm-kernel , linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 650 Lines: 22 On Wed, Jun 7, 2017 at 3:27 PM, Danny Milosavljevic wrote: > Adds support for some mixer controls to sun4i-codec: > - Line-In > - FM-In > - Mic 2 > - Capture Source > - Differential Line-In > > It also adds a mux for the capture source and the PGA for the MIC2 preamp. > > Where possible, it uses SOC_DAPM_DOUBLE in order to cut down on the number > of distinct controls in alsamixer. You are doing too many things in one patch. Please split this up into 1 patch per control/mux/source/widget added, preceded by patches for any required cleanups. ChenYu > Signed-off-by: Danny Milosavljevic