Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751475AbdFGH6H (ORCPT ); Wed, 7 Jun 2017 03:58:07 -0400 Received: from mail-ot0-f196.google.com ([74.125.82.196]:36247 "EHLO mail-ot0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751008AbdFGH6F (ORCPT ); Wed, 7 Jun 2017 03:58:05 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170523004107.536-1-palmer@dabbelt.com> <20170606230007.19101-1-palmer@dabbelt.com> <20170606230007.19101-13-palmer@dabbelt.com> From: Arnd Bergmann Date: Wed, 7 Jun 2017 09:58:04 +0200 X-Google-Sender-Auth: TrKq1VPu7AJe8Hz9SIeYHWY3wc4 Message-ID: Subject: Re: [PATCH 12/17] tty: New RISC-V SBI Console Driver To: Geert Uytterhoeven Cc: Palmer Dabbelt , Linux-Arch , "linux-kernel@vger.kernel.org" , Olof Johansson , albert@sifive.com, patches@groups.riscv.org, Greg KH , Jiri Slaby , "linuxppc-dev@lists.ozlabs.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1919 Lines: 53 On Wed, Jun 7, 2017 at 9:15 AM, Geert Uytterhoeven wrote: > CC (hypervisor) console folks > > On Wed, Jun 7, 2017 at 1:00 AM, Palmer Dabbelt wrote: >> This patch adds a new driver for the console availiable via the RISC-V >> SBI. This console is specified to be used for early boot messages, and >> is designed to be a very simple (albiet somewhat slow) console that is >> always availiable. All RISC-V systems have an SBI console. >> >> The SBI console is made availiable for early printk messages and is also >> availiable as a regular console. >> >> Signed-off-by: Palmer Dabbelt >> --- >> drivers/tty/hvc/Kconfig | 11 +++++ >> drivers/tty/hvc/Makefile | 1 + >> drivers/tty/hvc/hvc_sbi.c | 102 ++++++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 114 insertions(+) >> create mode 100644 drivers/tty/hvc/hvc_sbi.c >> >> diff --git a/drivers/tty/hvc/Kconfig b/drivers/tty/hvc/Kconfig >> index 574da15fe618..f3774adab240 100644 >> --- a/drivers/tty/hvc/Kconfig >> +++ b/drivers/tty/hvc/Kconfig >> @@ -114,4 +114,15 @@ config HVCS >> which will also be compiled when this driver is built as a >> module. >> >> +config HVC_SBI >> + bool "SBI console support" >> + depends on RISCV >> + select HVC_DRIVER >> + default y >> + help >> + This enables support for console output via RISC-V SBI calls, which >> + is normally used only during boot to output printk. >> + >> + If you don't know what do to here, say Y. >> + >> endif # TTY Please move this a little higher along with the other HVC_DRIVER implementations. >> + * RISC-V SBI interface to hvc_console.c >> + * based on drivers-tty/hvc/hvc_udbg.c >> + * >> + * Copyright (C) 2008 David Gibson, IBM Corporation >> + * Copyright (C) 2012 Regents of the University of California 2017? Arnd