Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751443AbdFGICB (ORCPT ); Wed, 7 Jun 2017 04:02:01 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:36207 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750739AbdFGIB6 (ORCPT ); Wed, 7 Jun 2017 04:01:58 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170523004107.536-1-palmer@dabbelt.com> <20170606230007.19101-1-palmer@dabbelt.com> <20170606230007.19101-7-palmer@dabbelt.com> From: Arnd Bergmann Date: Wed, 7 Jun 2017 10:01:57 +0200 X-Google-Sender-Auth: Kck8-gMmKTKTbw8dbzOZre6hVuo Message-ID: Subject: Re: [PATCH 06/17] pci: Add generic pcibios_{fixup_bus,align_resource} To: Geert Uytterhoeven Cc: Palmer Dabbelt , Linux-Arch , "linux-kernel@vger.kernel.org" , Olof Johansson , albert@sifive.com, patches@groups.riscv.org, Bjorn Helgaas , linux-pci Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1061 Lines: 29 On Wed, Jun 7, 2017 at 9:19 AM, Geert Uytterhoeven wrote: > CC pci folks > > On Wed, Jun 7, 2017 at 12:59 AM, Palmer Dabbelt wrote: >> While upstreaming the RISC-V port, it was pointed out that multiple >> architectures (arc, arm64, cris, microblaze, sh, tile) have copied the >> mostly empty versions of at least one of these functions. This defines >> weakly bound versions of the common functions so other architetures can >> use them. >> >> Signed-off-by: Palmer Dabbelt Thanks a lot for taking care of this! >> diff --git a/drivers/pci/bios.c b/drivers/pci/bios.c >> new file mode 100644 >> index 000000000000..ffe34c024aa8 >> --- /dev/null >> +++ b/drivers/pci/bios.c >> @@ -0,0 +1,42 @@ >> + >> +/* This file contains weakly bound functions that implement pcibios functions >> + * that some architectures have copied verbatim. >> + */ Instead of adding a new file, I would suggest adding the two functions next to their callers, in probe.c and setup-res.c, respectively. Arnd