Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751808AbdFGIux (ORCPT <rfc822;w@1wt.eu>);
        Wed, 7 Jun 2017 04:50:53 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:53010 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751473AbdFGIuQ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 7 Jun 2017 04:50:16 -0400
Date: Wed, 7 Jun 2017 10:50:10 +0200
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Bart Van Assche <Bart.VanAssche@sandisk.com>
Cc: "jslaby@suse.com" <jslaby@suse.com>,
        "andreyknvl@google.com" <andreyknvl@google.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "syzkaller@googlegroups.com" <syzkaller@googlegroups.com>,
        "kcc@google.com" <kcc@google.com>,
        "dvyukov@google.com" <dvyukov@google.com>
Subject: Re: tty: possible deadlock in tty_buffer_flush
Message-ID: <20170607085010.GB13755@kroah.com>
References: <CAAeHK+zOQRExvWzZQKpHhsdOnVah=zDsBdL2Q_SpamL1ttv4gg@mail.gmail.com>
 <1496796130.2692.26.camel@sandisk.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1496796130.2692.26.camel@sandisk.com>
User-Agent: Mutt/1.8.3 (2017-05-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1064
Lines: 30

On Wed, Jun 07, 2017 at 12:42:12AM +0000, Bart Van Assche wrote:
> On Mon, 2017-05-29 at 17:19 +0200, Andrey Konovalov wrote:
> > I've got the following error report while fuzzing the kernel with syzkaller.
> > 
> > On commit 5ed02dbb497422bf225783f46e6eadd237d23d6b (4.12-rc3).
> > 
> > ======================================================
> > WARNING: possible circular locking dependency detected
> > 4.12.0-rc3+ #369 Not tainted
> > ------------------------------------------------------
> > kworker/u9:1/31 is trying to acquire lock:
> >  (&buf->lock){+.+...}, at: [<ffffffff823dd42b>]
> > tty_buffer_flush+0xbb/0x3b0 drivers/tty/tty_buffer.c:221
> > 
> > but task is already holding lock:
> >  (&o_tty->termios_rwsem/1){++++..}, at: [<ffffffff823cd5d1>]
> > isig+0xa1/0x4d0 drivers/tty/n_tty.c:1100
> > 
> > which lock already depends on the new lock.
> 
> Hello Andrey,
> 
> I also see this warning but during regular boot (without running syzkaller).
> Do you perhaps have the time to bisect this?

Should be fixed in 4.12-rc4, right?

thanks,

greg k-h