Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751523AbdFGKR7 (ORCPT ); Wed, 7 Jun 2017 06:17:59 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40810 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751026AbdFGKR6 (ORCPT ); Wed, 7 Jun 2017 06:17:58 -0400 Date: Wed, 7 Jun 2017 12:17:51 +0200 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Geoff Levand , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 08/16] powerpc: ps3: use dev_groups and not dev_attrs for bus_type Message-ID: <20170607101751.GA25319@kroah.com> References: <20170606192221.1617-1-gregkh@linuxfoundation.org> <20170606192221.1617-9-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170606192221.1617-9-gregkh@linuxfoundation.org> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1462 Lines: 42 On Tue, Jun 06, 2017 at 09:22:13PM +0200, Greg Kroah-Hartman wrote: > The dev_attrs field has long been "depreciated" and is finally being > removed, so move the driver to use the "correct" dev_groups field > instead for struct bus_type. > > Cc: Geoff Levand > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc: > Signed-off-by: Greg Kroah-Hartman > --- > arch/powerpc/platforms/ps3/system-bus.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/arch/powerpc/platforms/ps3/system-bus.c b/arch/powerpc/platforms/ps3/system-bus.c > index 2d2e5f80a3d3..3e98b4ea3df9 100644 > --- a/arch/powerpc/platforms/ps3/system-bus.c > +++ b/arch/powerpc/platforms/ps3/system-bus.c > @@ -471,11 +471,13 @@ static ssize_t modalias_show(struct device *_dev, struct device_attribute *a, > > return (len >= PAGE_SIZE) ? (PAGE_SIZE - 1) : len; > } > +static DEVICE_ATTR_RO(modalias); > > -static struct device_attribute ps3_system_bus_dev_attrs[] = { > - __ATTR_RO(modalias), > - __ATTR_NULL, > +static struct attribute *ps3_system_bus_dev_attrs[] = { > + &dev_attr_modalias.attr, > + NULL, > }; > +ATTRIBUTE_GROUPS(ps3_system_bus); This should be: ATTRIBUTE_GROUPS(ps3_system_bus_dev); I've fixed it up and am now running it through 0-day. thanks, greg k-h